Merge branch-22.04 into branch-22.06 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apidsai#246) - Expose typestr property on CuImage object - Expose DLDataType and DLDataTypeCode under cucim.clara Without this patch, DLDataType and DLDataTypecode can be accessible with the below workaround. ```python >>> from cucim import CuImage >>> a = CuImage("notebooks/input/image.tif") >>> b = a.read_region((0,0), (10,10)) >>> import numpy as np >>> np.dtype(b.__array_interface__["typestr"]) # b would expose `__cuda_array_interface__` if memory is in GPU. dtype('uint8') ``` With this patch, we can convert data type to NumPy's dtype easily, and also can access cuCIM's DLDataType. ```python >>> from cucim import CuImage >>> a = CuImage("notebooks/input/image.tif") >>> b = a.read_region((0,0), (10,10)) >>> import numpy as np >>> b.typestr '|u1' >>> np.dtype(b.typestr) == np.uint8 True >>> from cucim.clara import DLDataType, DLDataTypeCode >>> b.dtype == DLDataType(DLDataTypeCode.DLUInt, 8, 1) True ``` Fixes rapidsai#243 Authors: - Gigon Bae (https://github.com/gigony) Approvers: - https://github.com/jakirkham URL: rapidsai#246
jakirkham
added
bug
As per rapidsai#225 Randomness updated to be applied to per image in the batch. Existing functionality of applying randomness on entire batch at once is unchanged. Authors: - https://github.com/shekhardw Approvers: - Gigon Bae (https://github.com/gigony) - https://github.com/jakirkham URL: rapidsai#231
|
I added a |
jakirkham
force-pushed
the
branch-22.06-merge-22.04
branch
from
55c10f7 to
7a11687
Compare
|
Sounds good. Actually needed to push an update (now done). So that works out. Anyways should be ready to go once CI completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses merge conflict seen in PR ( #257 ).