Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Refresh pylibcudf guide #15856

Merged
merged 6 commits into from
Aug 21, 2024
Merged

DOC: Refresh pylibcudf guide #15856

merged 6 commits into from
Aug 21, 2024

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented May 24, 2024 •
edited by vyasr
Loading

Description

This PR updates the pylibcudf dev guide with some more recent recommendations.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lithomas1 lithomas1 added doc Documentation non-breaking Non-breaking change labels May 24, 2024
@vyasr vyasr added the pylibcudf Issues specific to the pylibcudf package label May 28, 2024
wence-
wence- requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording suggestions.

docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Show resolved Hide resolved
@wence-
Copy link
Contributor

wence- commented Jun 4, 2024

@lithomas1 you'll want to merge branch-24.08 to fix the build failures.

@github-actions github-actions bot removed the pylibcudf Issues specific to the pylibcudf package label Jun 4, 2024
@lithomas1
Copy link
Contributor Author

@lithomas1 you'll want to merge branch-24.08 to fix the build failures.

Thanks for the review.

I think I was planning on having this PR sit in draft for a while, until we got most of the pylibcudf API done.
(I've been jotting down most of the stuff as we've finished discussing them.)

I'm definitely happy to address any comments that y'all have in the meantime, though.

@vyasr
Copy link
Contributor

vyasr commented Jun 4, 2024

Yeah feel free to do this however you see fit. I wasn't planning to review until it was out of draft.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Aug 19, 2024
@vyasr vyasr changed the base branch from branch-24.08 to branch-24.10 August 19, 2024 20:17
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Aug 19, 2024
@vyasr vyasr requested a review from wence- August 19, 2024 21:08
@vyasr vyasr marked this pull request as ready for review August 19, 2024 21:08
@vyasr
Copy link
Contributor

vyasr commented Aug 21, 2024

/merge

@rapids-bot rapids-bot bot merged commit bf2ee32 into rapidsai:branch-24.10 Aug 21, 2024
81 checks passed
@lithomas1 lithomas1 deleted the pylibcudf-docs branch August 21, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @wence- @vyasr