Introduce some simple benchmarks for rolling window aggregations #17613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
wence-
added
improvement
mythrocks
approved these changes
Dec 17, 2024
|
I've re-kicked the CI, because of transient failures. |
wence-
force-pushed
the
wence/fea/rolling-benchmark
branch
from
f1a6a36 to
cb2530f
Compare
3 tasks
vyasr
approved these changes
Dec 21, 2024
karthikeyann
reviewed
Jan 6, 2025
| #include <benchmarks/fixture/benchmark_fixture.hpp> | ||
|
|
||
| #include <cudf/aggregation.hpp> | ||
| #include <cudf/copying.hpp> |
There was a problem hiding this comment.
nit: "cudf/copying.hpp" is this include required?
There was a problem hiding this comment.
Let me check, quite possibly not.
| NVBENCH_BENCH_TYPES(bench_row_fixed_rolling_sum, | ||
| NVBENCH_TYPE_AXES(nvbench::type_list<std::int32_t, double>)) | ||
| .set_name("row_fixed_rolling_sum") | ||
| .add_int64_power_of_two_axis("num_rows", {14, 22, 28}) |
There was a problem hiding this comment.
nit: Is there any reason for choice of these numbers of num_rows? or just random.
There was a problem hiding this comment.
Smallish, mediumish, and largeish. But other than that, not particularly attached to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we did not have any benchmarks for rolling aggregations. Introduce some, so we can measure the effects of any performance improvements we might make.
Checklist