Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix in MG coarsen_grph #1596

Merged
merged 2 commits into from
May 12, 2021
Merged

Bug fix in MG coarsen_grph #1596

merged 2 commits into from
May 12, 2021

Conversation

seunghwak
Copy link
Contributor

  • Bug fix in MG coarsen_graph

@seunghwak seunghwak requested a review from a team as a code owner May 11, 2021 13:47
@seunghwak
Copy link
Contributor Author

@ChuckHastings

@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels May 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #1596 (2f2e475) into branch-0.20 (250f2c8) will decrease coverage by 1.30%.
The diff coverage is 62.80%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #1596      +/-   ##
===============================================
- Coverage        61.04%   59.73%   -1.31%     
===============================================
  Files               73       79       +6     
  Lines             3219     3482     +263     
===============================================
+ Hits              1965     2080     +115     
- Misses            1254     1402     +148
Impacted Files Coverage Δ
python/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/components/connectivity.py 95.65% <ø> (ø)
python/cugraph/dask/centrality/katz_centrality.py 29.16% <ø> (ø)
python/cugraph/dask/link_analysis/pagerank.py 21.87% <0.00%> (ø)
python/cugraph/dask/traversal/bfs.py 25.00% <0.00%> (-2.59%) ⬇️
python/cugraph/traversal/ms_bfs.py 11.11% <ø> (ø)
...ure/graph_implementation/simpleDistributedGraph.py 22.72% <22.72%> (ø)
python/cugraph/generators/rmat.py 34.44% <34.44%> (ø)
python/cugraph/linear_assignment/lap.py 71.42% <50.00%> (-10.39%) ⬇️
python/cugraph/structure/number_map.py 64.82% <57.14%> (+1.00%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb8583...2f2e475. Read the comment docs.

ChuckHastings
ChuckHastings approved these changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentation thing. Otherwise I've tested with this and it looks good.

cpp/src/experimental/coarsen_graph.cu
labels + major_labels.size(),
major_labels.begin());
if (col_comm_rank == i) {
// FIXME: this copy is unnecessary, beter fix RAFT comm's bcast to take const iterators for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'beter' should be 'better'.

@ChuckHastings ChuckHastings mentioned this pull request May 11, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request May 12, 2021
@ChuckHastings
Bug fix for MNMG Louvain (#1597)
85ceac3 
in MNMG mode, clusters assigned to different GPUs can increase between iterations.

Merge after #1596 

closes #1586

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #1597
@BradReesWork BradReesWork added this to the 21.06 milestone May 12, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d97638d into rapidsai:branch-0.20 May 12, 2021
@seunghwak seunghwak deleted the bug_mg_coarsen_graph branch June 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
21.06
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @BradReesWork @ChuckHastings