Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in MG coarsen_grph #1596

Merged
merged 2 commits into from
May 12, 2021
Merged

Bug fix in MG coarsen_grph #1596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b36c09
bug fix
seunghwak May 11, 2021
2f2e475
additional bug fix
seunghwak May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions cpp/src/experimental/coarsen_graph.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,14 @@ coarsen_graph(
store_transposed ? graph_view.get_number_of_local_adj_matrix_partition_cols(i)
: graph_view.get_number_of_local_adj_matrix_partition_rows(i),
handle.get_stream());
// FIXME: this copy is unnecessary, beter fix RAFT comm's bcast to take const iterators for
// input
thrust::copy(rmm::exec_policy(handle.get_stream())->on(handle.get_stream()),
labels,
labels + major_labels.size(),
major_labels.begin());
if (col_comm_rank == i) {
// FIXME: this copy is unnecessary, beter fix RAFT comm's bcast to take const iterators for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'beter' should be 'better'.

// input
thrust::copy(rmm::exec_policy(handle.get_stream())->on(handle.get_stream()),
labels,
labels + major_labels.size(),
major_labels.begin());
}
device_bcast(col_comm,
major_labels.data(),
major_labels.data(),
Expand Down Expand Up @@ -455,7 +457,7 @@ coarsen_graph(
cur_size;
thrust::copy(rmm::exec_policy(handle.get_stream())->on(handle.get_stream()),
src_edge_first,
src_edge_first + edgelist_major_vertices.size(),
src_edge_first + number_of_partition_edges,
dst_edge_first);
}
}
Expand Down