Add parameter checks to BFS and SSSP in C API #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
bug
seunghwak
approved these changes
Oct 24, 2022
jnke2016
approved these changes
Oct 26, 2022
|
rerun tests |
1 similar comment
|
rerun tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2844 +/- ##
===============================================
Coverage ? 62.60%
===============================================
Files ? 114
Lines ? 6397
Branches ? 0
===============================================
Hits ? 4005
Misses ? 2392
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rerun tests |
3 similar comments
|
rerun tests |
|
rerun tests |
|
rerun tests |
|
rerun tests |
|
This is a good change but can there be an updated test to cover this change? |
|
rerun tests |
rlratzel
approved these changes
Nov 3, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MG testing resulted in discovering an assumption in the C API about types that needs to be validated. Added checks to BFS and SSSP so that the type checks will be done right away before trying to interpret the data incorrectly.
Won't pass until #2847 is addressed