Ensure correct data type #2847
Merged
Ensure correct data type #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2847 +/- ##
===============================================
Coverage ? 60.41%
===============================================
Files ? 114
Lines ? 6551
Branches ? 0
===============================================
Hits ? 3958
Misses ? 2593
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ChuckHastings
approved these changes
Oct 25, 2022
BradReesWork
added
improvement
BradReesWork
approved these changes
Oct 26, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
MG testing resulted in discovering an assumption in the C API about types that needs to be validated. Added checks to BFS and SSSP so that the type checks will be done right away before trying to interpret the data incorrectly. Won't pass until #2847 is addressed Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) - Joseph Nke (https://github.com/jnke2016) - Rick Ratzel (https://github.com/rlratzel) URL: #2844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
global_idcolumn representing the renumberededgelistare of type int64 by default and this is problematic if the user's input dataframe is of typeint32.This PR:
dtypeunless non integers vertices are provided.source'sdtypeinBFSmatches edgelistdtype.closes #2845
close #2846