Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept empty --matrix values as CLI flag #17

Closed
ajschmidt8 opened this issue Nov 4, 2022 · 1 comment · Fixed by #18
Closed

Accept empty --matrix values as CLI flag #17

ajschmidt8 opened this issue Nov 4, 2022 · 1 comment · Fixed by #18

Comments

@ajschmidt8
Copy link
Member

Currently, if you run the following command:

rapids-dependency-file-generator \
  --output conda \
  --file_key test \
  --matrix "" 

you'll get an error that says:

Traceback (most recent call last):
  File "/home/aj/miniconda3/bin/rapids-dependency-file-generator", line 33, in <module>
    sys.exit(load_entry_point('rapids-dependency-file-generator', 'console_scripts', 'rapids-dependency-file-generator')())
  File "/home/aj/code/nvidia/dependency-file-generator/src/rapids_dependency_file_generator/cli.py", line 63, in main
    args = validate_args(argv)
  File "/home/aj/code/nvidia/dependency-file-generator/src/rapids_dependency_file_generator/cli.py", line 44, in validate_args
    raise ValueError(
ValueError: The following arguments must be used together:
  --file_key
  --output
  --matrix

Empty --matrix values should probably be allowed. One use case is for environments generated for the check_style.sh scripts, where most of the dependencies will just be pure Python dependencies that don't vary per CUDA version, Python version, or architecture.

@ajschmidt8
Copy link
Member Author

ajschmidt8 added a commit to rapidsai/rapids-cmake that referenced this issue Nov 15, 2022
Now that rapidsai/dependency-file-generator#17 has been closed, this `FIXME` can be removed.
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue Nov 15, 2022
Now that rapidsai/dependency-file-generator#17 has been closed, this `FIXME` can be removed.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Sevag H (https://github.com/sevagh)
  - Jake Awe (https://github.com/AyodeAwe)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant