Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rapids-dependency-file-generator FIXME #305

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Remove rapids-dependency-file-generator FIXME #305

merged 1 commit into from
Nov 15, 2022

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Nov 15, 2022 •
edited
Loading

Description

Now that rapidsai/dependency-file-generator#17 has been closed, this FIXME can be removed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@ajschmidt8
Remove rapids-dependency-file-generator FIXME
9c2ca05 
Now that rapidsai/dependency-file-generator#17 has been closed, this `FIXME` can be removed.
@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 15, 2022
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner November 15, 2022 19:20
@robertmaynard
Copy link
Contributor

@gpucibot merge

1 similar comment
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 70a5109 into branch-22.12 Nov 15, 2022
@ajschmidt8 ajschmidt8 deleted the fix-style-env branch November 15, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@sevagh sevagh sevagh approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajschmidt8 @robertmaynard @sevagh @AyodeAwe