[core] Add more message when accessing a dead actor. #34697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
rkooo567
approved these changes
Apr 25, 2023
| name = "exported_internal", | ||
| srcs = glob( | ||
| [ | ||
| "src/ray/internal/internal.cc", |
There was a problem hiding this comment.
Guess it is unrelated changes? Looks okay to include in this PR to me.
There was a problem hiding this comment.
Actually it is... There is some method used in this file got impacted by this PR. So when I compile it just failed :(
I notice it seems not useful, so just delete that file.
rkooo567
added
the
@author-action-required
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
## Why are these changes needed? When any ray worker access the actor which doesn't belong to the cluster, it'll crash. This is really bad user experience because: - The user will lose ray worker or driver. - The error message is not very useful. This PR fixed it by avoiding crash and throw exception instead. When the user accidentially access an actor which doesn't belong to this cluster, it'll get an Exception with message: `It might be dead or it's from a different cluster`. This PR also deleted some code that's not useful. Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
## Why are these changes needed? When any ray worker access the actor which doesn't belong to the cluster, it'll crash. This is really bad user experience because: - The user will lose ray worker or driver. - The error message is not very useful. This PR fixed it by avoiding crash and throw exception instead. When the user accidentially access an actor which doesn't belong to this cluster, it'll get an Exception with message: `It might be dead or it's from a different cluster`. This PR also deleted some code that's not useful.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When any ray worker access the actor which doesn't belong to the cluster, it'll crash. This is really bad user experience because:
This PR fixed it by avoiding crash and throw exception instead. When the user accidentially access an actor which doesn't belong to this cluster, it'll get an Exception with message:
It might be dead or it's from a different cluster.This PR also deleted some code that's not useful.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.