-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core]create internal module for thridparty system compatible building #44066
Conversation
@jjyao Now it block build the mobius project update ray version (old version -> ray lastest 2.9.3) ray-project/mobius#60 . |
@robertnishihara @raulchen @SongGuyang Anyone can take over ray core module management? Seems no one can go on developing. |
Seems that the exported internal flags were deleted accidentally. I will merge this PR if there are no more other comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add these code to mobius
repo?
We should add some comment saying that the code is used by an external repo otherwise it's guaranteed to be removed in the future by someone without context.
Thirdparty can not decide what symbols ray should be exported? Usually opensource system made it in main repo. |
…into revert-internal-module-removed
#include "ray/common/id.h" | ||
#include "ray/core_worker/common.h" | ||
#include "ray/stats/metric.h" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add comments to the code saying where it's used so people don't accidentally delete it again in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add comments to the code saying where it's used so people don't accidentally delete it again in the future?
Comments had been added in internal header file.
Exporting internal module
Related issue number
Closes #44065
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.