OpenSSL 1.1.1q failing to build #2009

stack · 2022-07-11T17:13:48Z

stack
Jul 11, 2022

This is a fresh install of macOS 12.4 on a M1 Pro MacBook Pro. Attempting to install Ruby 3.1.2.

Xcode 13.4.1
Homebrew installed as of today (2022-07-11).
ruby-build 20220710

The OpenSSL 1.1.1q fails to build in the tests:

Downloading openssl-1.1.1q.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/d7939ce614029cdff0b6c20f0e2e5703158a489a72b2507b8bd51bf8c8fd10ca
Installing openssl-1.1.1q...

BUILD FAILED (macOS 12.4 using ruby-build 20220710)

Inspect or clean up the working tree at /var/folders/4y/m2qk7qcx099b6g_zt98mp3jh0000gn/T/ruby-build.20220711120126.51360.08iZ3t
Results logged to /var/folders/4y/m2qk7qcx099b6g_zt98mp3jh0000gn/T/ruby-build.20220711120126.51360.log

Last 10 log lines:
clang  -Iinclude -arch arm64 -O3 -Wall -D_REENTRANT -DZLIB -DZLIB_SHARED -DNDEBUG -I/Users/stephen/.rbenv/versions/3.1.2/include  -MMD -MF test/v3ext.d.tmp -MT test/v3ext.o -c -o test/v3ext.o test/v3ext.c
clang  -Iinclude -arch arm64 -O3 -Wall -D_REENTRANT -DZLIB -DZLIB_SHARED -DNDEBUG -I/Users/stephen/.rbenv/versions/3.1.2/include  -MMD -MF test/v3nametest.d.tmp -MT test/v3nametest.o -c -o test/v3nametest.o test/v3nametest.c
test/v3ext.c:201:24: error: implicitly declaring library function 'memcmp' with type 'int (const void *, const void *, unsigned long)' [-Werror,-Wimplicit-function-declaration]
        if (!TEST_true(memcmp(ip1->data, ip2->data, ip1->length) <= 0))
                       ^
test/v3ext.c:201:24: note: include the header <string.h> or explicitly provide a declaration for 'memcmp'
1 error generated.
make[1]: *** [test/v3ext.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2

Answered by eregon

Jul 11, 2022

OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration ruby-build/rbenv/asdf ... helps and works around the missing include in openssl.

The default of -Werror,-Wimplicit-function-declaration is macOS-specific (so this does not happen on Linux).

An easy fix for 3.1.2 would be to install openssl 3 instead of openssl 1.1, thoughts on that @mislav? => #2000

View full answer

eregon · 2022-07-11T17:45:53Z

eregon
Jul 11, 2022
Collaborator

It's a bug in openssl upstream: openssl/openssl#18720

0 replies

eregon · 2022-07-11T17:54:05Z

eregon
Jul 11, 2022
Collaborator

OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration ruby-build/rbenv/asdf ... helps and works around the missing include in openssl.

The default of -Werror,-Wimplicit-function-declaration is macOS-specific (so this does not happen on Linux).

An easy fix for 3.1.2 would be to install openssl 3 instead of openssl 1.1, thoughts on that @mislav? => #2000

4 replies

abhishekbedi1432 Jul 20, 2022

Run your ruby install with the argument
OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration rbenv install [version]

Reference: #2009 (comment)

jetdotrb Jul 25, 2022

Thanks! It works for me!

eregon Jul 25, 2022
Collaborator

With the latest release of ruby-build there is no need for this workaround anymore: #2011

dtsdwarak Nov 22, 2022

Thanks much for the fix!

stack · 2022-07-11T18:00:43Z

stack
Jul 11, 2022
Author

The OPENSSL_CFLAGS flags do fix the issue for me. 3.1.2 installed without issue.

0 replies

eregon · 2022-07-11T18:02:23Z

eregon
Jul 11, 2022
Collaborator

Alright, then I think we can close this.
Hopefully openssl makes a new 1.1 release soon with the fix so there is no need to work around it.

0 replies

moemylawn · 2022-07-12T19:37:31Z

moemylawn
Jul 12, 2022

Could you try if OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration helps?

The default of -Werror,-Wimplicit-function-declaration is macOS-specific (so this does not happen on Linux).

An easy fix for 3.1.2 would be to install openssl 3 instead of openssl 1.1, thoughts on that @mislav? => #2000

i'm sorry. What does this mean. How do I do that?

0 replies

jtethras · 2022-07-12T20:09:01Z

jtethras
Jul 12, 2022

Could you try if OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration helps?
The default of -Werror,-Wimplicit-function-declaration is macOS-specific (so this does not happen on Linux).
An easy fix for 3.1.2 would be to install openssl 3 instead of openssl 1.1, thoughts on that @mislav? => #2000

i'm sorry. What does this mean. How do I do that?

Run your ruby install with the argument
OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration rbenv install [version]

1 reply

besi Oct 4, 2022

No love here unfortunately. I did open a new issue #2060

moemylawn · 2022-07-12T20:12:19Z

moemylawn
Jul 12, 2022

OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration

lifesaver. thanks

0 replies

stack · 2022-07-13T14:59:34Z

stack
Jul 13, 2022
Author

20220713 also fixed this issue for Ruby 3.1.x by moving to OpenSSL 3.

0 replies

eregon · 2022-07-14T12:09:20Z

eregon
Jul 14, 2022
Collaborator

@mislav @hsbt Do you think we should automatically add the include/patch openssl 1.1.1q before building it?
I wish we would not need to, but openssl doesn't seem to have a made a new release after this broken release and we're already 9 days after the release.
Given it's a trivial and safe change, not related to security I'm starting to consider it, otherwise I would not.

Another thought was could we just revert to 1.1.1p, but that would mean missing a CVE fix (https://www.openssl.org/news/openssl-1.1.1-notes.html), which seems bad.

5 replies

hsbt Jul 14, 2022
Maintainer

Can we add OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration option to 1.1.1q temporally? I agreed to not use this option by default and don't use 1.1.1p.

eregon Jul 14, 2022
Collaborator

Right, that's probably a bit easier than to change a file. It's a bit less safe (there could be another missing header on some uncommon OS and that could be problematic, here it's just in tests which are not run so doesn't matter), but I think it's still OK for 1.1.1q.
I guess most operating systems use a patch to deal with this situation, so changing the file is closer to that, but it's not very important.

mislav Jul 14, 2022
Maintainer

I believe it should be safe to auto-patch 1.1.1q as long as the patch is taken verbatim from OpenSSL upstream. I think the patch will be a more robust solution than setting environment variables.

hsbt Jul 15, 2022
Maintainer

We should apply this https://github.com/openssl/openssl/commit/f9e578e720bb35228948564192adbe3bc503d5fb.diff

eregon Jul 21, 2022
Collaborator

Done in #2011 (thanks @hsbt!) and released as v20220721

aishtiaq7 · 2022-11-23T11:16:07Z

aishtiaq7
Nov 23, 2022

Still having issues even after trying this command:
OPENSSL_CFLAGS=-Wno-error=implicit-function-declaration rbenv install 2.7.6

I'm trying to install React-Native on my MacOS M1, React-Native is requiring 2.7.6 version of ruby. But still seems to run onto this issue. Please help.

2 replies

mislav Nov 23, 2022
Maintainer

Hi, without the full log, we cannot tell what happened. Also, note that your build failure doesn't belong in this discussion thread as we were discussing build failures in 1.1.1q, which had a known bug, and you're building a more recent 1.1.1s version.

My general advice to everyone building Ruby on macOS would be to install OpenSSL via Homebrew (brew install [email protected]) and then link Ruby to that:

RUBY_CONFIGURE_OPTS="--with-openssl-dir=$(brew --prefix [email protected])" rbenv install 2.7.6

hsbt Nov 23, 2022
Maintainer

/usr/local/bin/clang is not official toolchanins for Apple Silicon. Can you uninstall them and reinstall Ruby 2.7 with rbenv?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenSSL 1.1.1q failing to build #2009

{{title}}

Replies: 10 comments 12 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

OpenSSL 1.1.1q failing to build #2009

Replies: 10 comments · 12 replies

eregon Jul 11, 2022 Collaborator

eregon Jul 11, 2022 Collaborator

eregon Jul 25, 2022 Collaborator

stack Jul 11, 2022 Author

eregon Jul 11, 2022 Collaborator

stack Jul 13, 2022 Author

eregon Jul 14, 2022 Collaborator

hsbt Jul 14, 2022 Maintainer

eregon Jul 14, 2022 Collaborator

mislav Jul 14, 2022 Maintainer

hsbt Jul 15, 2022 Maintainer

eregon Jul 21, 2022 Collaborator

mislav Nov 23, 2022 Maintainer

hsbt Nov 23, 2022 Maintainer

Replies: 10 comments 12 replies

eregon
Jul 11, 2022
Collaborator

eregon
Jul 11, 2022
Collaborator

eregon Jul 25, 2022
Collaborator

stack
Jul 11, 2022
Author

eregon
Jul 11, 2022
Collaborator

stack
Jul 13, 2022
Author

eregon
Jul 14, 2022
Collaborator

hsbt Jul 14, 2022
Maintainer

eregon Jul 14, 2022
Collaborator

mislav Jul 14, 2022
Maintainer

hsbt Jul 15, 2022
Maintainer

eregon Jul 21, 2022
Collaborator

mislav Nov 23, 2022
Maintainer

hsbt Nov 23, 2022
Maintainer