fix: order same zIndex elements by updateTreeOrder #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely not an ideal solution, but it is better than having an wrongly ordered zIndex elements
uguraslan
requested review from
frank-weindel,
erikhaandrikman and
michielvandergeest
|
@uguraslan I updated the solution to be compatible with unstable Array.sort. This is only relevant on old chrome browsers, because webkit had an non-stable Array.sort algorithm. |
jorge-graca-sky
commented
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When elements have the same zIndex they should respect the renderTree. There is a clear attempt at that by using the updateTreeOrder to sort the elements, however the code that triggered the re-sort was removed:
38285e0
93b301b
Since this sort happens only when the tree changes it has a very very low cost, performance wise and is much better than having a wrongly ordered zIndex array.
Other suggestions to fix this bug are very welcome.