Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order same zIndex elements by updateTreeOrder #441

Merged
merged 4 commits into from
Oct 10, 2023
Merged

fix: order same zIndex elements by updateTreeOrder #441

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c617eff
fix: order same zIndex elements by updateTreeOrder
jorge-graca-sky Jan 18, 2023
606c7f9
Update ElementCore.mjs
jorge-graca-sky Feb 9, 2023
95f07ec
Alter to be compatible with unstable array.sort
jorge-graca-sky Sep 8, 2023
59f804e
remove bad comment
jorge-graca-sky Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/tree/core/ElementCore.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2031,6 +2031,9 @@ export default class ElementCore {
a.splice(ptr);
}
} else {
a.splice(n); // Remove items that were sorted in b array, so that we can sort a
+ // Beware that the function passed here to Array.sort must be stable
+ a.sort(ElementCore.sortZIndexedChildren); // Needed because items with same _zIndex may not be ordered by _updateTreeOrder
// Merge-sort arrays;
ptr = 0;
let i = 0;
Expand Down