Draft: signal handlers sync project views and tasks #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyPyDavid
force-pushed
the
feat-sync-project-views-and-tasks
branch
from
15fd305 to
d708437
Compare
Signed-off-by: David Wallace <[email protected]>
MyPyDavid
force-pushed
the
feat-sync-project-views-and-tasks
branch
from
d708437 to
9065876
Compare
jochenklar
requested changes
Jan 9, 2025
| from rdmo.projects.models import Project | ||
| from rdmo.tasks.models import Task | ||
|
|
||
| from .helpers import assert_other_projects_unchanged |
There was a problem hiding this comment.
I like this. We should stick to helpers for tests (and use sparingly) and utils for regular code.
| @@ -0,0 +1,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
I don't think those methods should exist, this should be inline in the handlers (and without the getattr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the settings this PR removes:
PROJECT_REMOVE_VIEWS = Trueand adds:
The
projects/handlers.pyare refactored into aproject/handlerspackage with aproject/handlers/generic_handlers.pymodule that contains the logic for signal receivers.It handles the signals for changes in
View.catalogs,View.sites,View.groupsas well asTask.catalogs,Task.sites,Task.groupsand updates theproject.viewsorprojects.tasks.Tests, that only use db
view.catalog.add(...)methods and not the client, are included.Related issues: #966, #1198, #345, #431
Motivation and Context
How has this been tested?
Screenshots (if appropriate)