Remove views from existing projects on view update

[m6121]

This PR aims at fixing #345 by automatically updating existing projects on saving of views. I added a separate view and project in the test-data in order to test this case.

[jochenklar]

Thanks @m6121 , we need to talk about this though. We have a few more cases we should treat the same: views can be restricted to sites and groups as well. Also the same goes for tasks.

On the technical level, maybe a post_save signal for View would be better, since it also triggers when the view is updated through the admin interface.

[m6121]

Hi @jochenklar, I refactored the code to cover the three dependencies and implemented a configuration flag in order to enable this feature. However, the tests did not yet cover all possible cases. I employed the m2m_changed signal which is connected in the views/apps.py.

[coveralls]

Coverage increased (+0.08%) to 90.581% when pulling 3c8b920 on ubrostock:view_update into b12720c on rdmorganiser:dev.

[m6121]

I added some tests and fixed the logic and think this is in a status worth a review, especially the implemented logic.

[jochenklar]

Hey @m6121 , thanks a lot, looks good, I added a few (minor) comments inline.

I wonder if we should move the signals and handlers to the projects app since it changes stuff in projects (Project). Not sure about it. I tried so far to keep kind of a hierarchy between the django apps.

core -> conditions -> projects
        domain
        ...

and not import Project in views. But maybe this is not super important, what do you think?

In another project I put the handlers in a separate file handlers.py to keep the apps.py file small: https://github.com/django-daiquiri/daiquiri/blob/master/daiquiri/auth/apps.py#L10, should we do this in rdmo as well or is this overkill?

[jochenklar]

Oh and it would be good if you indent the fixtures with 2 spaces and the rest with 4 spaces. I have a trailing white space plugin and a flake8 plugin in my editor which makes me even more pedantic!

[m6121]

I moved the implementation into the projects app. I think this makes sense as you suggested. Furthermore, I also moved it from signals.py to handlers.py. However, I am not happy with the linking into the projects/apps.py due to the configuration flag.

[m6121]

I also adjusted the indentation to two spaces. The formatting that I originally committed was created using the djangoadmin-command as we proposed here: https://github.com/rdmorganiser/rdmo/blob/master/docs/dev.md

python manage.py dumpdata --indent 4 -o ../rdmo/testing/fixtures/views.json views

Even when using --indent 2 there are some small differences between the formattings.

[m6121]

Hi @jochenklar, thanks a lot for your review! Hope I addressed all comments. Not sure if we should change the import of the handlers to be more independent of the feature flag. Despite this, I think it is ready for a review.

[jochenklar]

Thanks! I think we need to fix the dev.md file. I usually use just python manage.py dumpdata views > ../rdmo/testing/fixtures/views.json. I don't know why we stated 4 spaces in the file, maybe @triole knows. Otherwise I think we are done, @triole can you have a look.

[m6121]

I think the dumping commands in the dev.md file were proposed by me. So, we can safely replace them by your command. Thanks a lot for reviewing, again.