Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote debugging deprecation header #2081

Merged

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Sep 19, 2023

Summary

In React Native 0.73 we are deprecating Remote JSC Debugging (the /debugger-ui endpoint). This PR adds an informational warning header to this page as a signal to users of this change.

This will be supported by (upcoming) improvements to React Native's debugging docs.

Test plan

Light Dark
image image

@huntie huntie requested a review from motiz88 September 19, 2023 12:57
</p>
<p>
Please use the
<strong>Open Debugger</strong> workflow to debug apps using Hermes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@motiz88 One thought here is whether we should mention or link any info on future JSC direct debugging capabilities — i.e. pointing to an umbrella issue on GitHub that we open during 0.73's lifetime, to gather signal on users who may need this. This issue would reinforce that JSC debugging is no longer directly supported, but that we're looking for interested owners to implement JSC support in the new debugging stack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huntie please feel free to followup on this in a separate PR if you feel this is gonna be helpful

@huntie huntie force-pushed the deprecate-jsc-remote-debugging branch from a78e061 to 46404e0 Compare September 19, 2023 13:50
@thymikee thymikee merged commit 29db2ac into react-native-community:main Sep 20, 2023
@huntie huntie deleted the deprecate-jsc-remote-debugging branch September 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants