Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote debugging deprecation header #2081

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add remote debugging deprecation header #2081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/cli-debugger-ui/src/ui/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,32 @@ body.dark {
input[type='checkbox'] {
vertical-align: middle;
}

.warning {
box-sizing: border-box;
max-width: 800px;
padding: 16px;
margin-bottom: 1em;
border-left: 5px solid rgb(230, 167, 0);
border-radius: 6px;
background-color: rgb(255, 248, 230);
box-shadow: rgba(0, 0, 0, 0.1) 0px 1px 2px 0px;
color: rgb(77, 56, 0);
font-size: 16px;
font-weight: 500;
line-height: 1.6;
}

.warning p {
margin-top: 0;
}

.warning p:last-child {
margin: 0;
}

.dark .warning {
background: rgb(77, 56, 0);
border-left-color: rgb(230, 167, 0);
color: rgb(255, 248, 230);
}
21 changes: 21 additions & 0 deletions packages/cli-debugger-ui/src/ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,27 @@
</head>
<body>
<div class="content">
<div class="warning">
<p>
Remote JavaScript debugging (this workflow) is
<strong>deprecated</strong> in React Native 0.73 and will be removed
in React Native 0.74.
</p>
<p>
Please use the
<strong>Open Debugger</strong> workflow to debug apps using Hermes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@motiz88 One thought here is whether we should mention or link any info on future JSC direct debugging capabilities — i.e. pointing to an umbrella issue on GitHub that we open during 0.73's lifetime, to gather signal on users who may need this. This issue would reinforce that JSC debugging is no longer directly supported, but that we're looking for interested owners to implement JSC support in the new debugging stack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huntie please feel free to followup on this in a separate PR if you feel this is gonna be helpful

directly. This can be accessed from the Dev Menu or by pressing
<kbd class="shortcut">j</kbd> in the CLI.
</p>
<p>
Learn more about debugging in React Native in the
<strong
><a href="https://reactnative.dev/docs/debugging"
>refreshed docs</a
></strong
> 📖.
</p>
</div>
<label for="dark">
<input type="checkbox" id="dark" onclick="Page.toggleDarkTheme()" />
Dark Theme
Expand Down