Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes after publishing a product, the product is "not found" #2249

Closed
spencern opened this issue May 11, 2017 · 6 comments
Closed

Sometimes after publishing a product, the product is "not found" #2249

spencern opened this issue May 11, 2017 · 6 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@spencern
Copy link
Contributor

When creating a new product, sometimes it becomes "not found" after publishing it.
I don't have perfect reproduction steps for this one yet, but it's happened to me several times.
Here's a video:

http://recordit.co/uLT7rKSA0l

Versions

Node: 7.8.0
NPM: 4.5.0
Meteor Node: 4.8.2
Meteor NPM: 4.5.0
Reaction CLI: 0.8.1
Reaction: 1.1.1
Reaction branch: development
Docker: 17.03.1-ce
@brent-hoover
Copy link
Collaborator

@spencern this has been happening to me as well but I have not been able to reliably reproduce it. It will still appear in the grid but when you go to the PDP I get the 404 page

@brent-hoover brent-hoover added the bug For issues that describe a defect or regression in the released software label May 16, 2017
@aaronjudd
Copy link
Contributor

I've seen this, so it can be reproduced... but not sure the steps..

@spencern
Copy link
Contributor Author

Was able to reproduce this on the release-1.3 branch

@brent-hoover
Copy link
Collaborator

Making this minor because it's bad when it happens but doesn't happen very often

@prinzdezibel
Copy link
Contributor

On place this can happen is in the short time between publishing and redirection:

I'm refactoring this as part of #2246, because the page reload is not good anyway. Not unlikely, that this problem gets resolved as part of it.

@prinzdezibel
Copy link
Contributor

prinzdezibel commented Feb 14, 2018

One example, where it happens reliable is when navigating to ProductGrid before acutally publishing a change to the permalink.
unpulished_notfound
See the gif as example.

This is addressed through the following PR (#3748).

There's also another PR on how the changed handles are published as part of ticket #2246, which involves a tracker not being executed when the product handle changes. This is also one situation where the behavior described in this ticket can occur. With this PR applied, I haven't seen this specific problem any longer: (#3755)

@prinzdezibel prinzdezibel self-assigned this Feb 14, 2018
prinzdezibel added a commit that referenced this issue Feb 14, 2018
What it does:
- Prevent unpublished handle changes to be used when assembling a link
URL to PDP.

What is does not:
- Ensure that the "not found" template is rendered in certain situations
(which I don't know what these are exactly) AFTER publishing a product.

How it does that:
If a product has unpublished changes, they published state is in
products.__published. Use that for building the perma-link from
products.__published.handle.

Adresses not the problem of the "not found"
@prinzdezibel prinzdezibel removed their assignment Feb 28, 2018
@aldeed aldeed closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

5 participants