Fix: Changing the permalink before publishing a product results in "not found" #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What it does: - Prevent unpublished handle changes to be used when assembling a link URL to PDP. What is does not: - Ensure that the "not found" template is rendered in certain situations (which I don't know what these are exactly) AFTER publishing a product. How it does that: If a product has unpublished changes, they published state is in products.__published. Use that for building the perma-link from products.__published.handle. Adresses not the problem of the "not found"
prinzdezibel
changed the title
|
@jshimko This is a quick one-liner, let's move that through. thanks. |
jshimko
approved these changes
Mar 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3858
If the permalink of a product is changed, but not published yet, the permalink is assembled with the new (yet unpublished) handle, which leads to the PDP rendering a "Not found" template.
See this animated gif:
What it does:
URL to PDP.
What is does not:
(which I don't know what these are exactly) AFTER publishing a product. This is a separate issue: Sometimes after publishing a product, the product is "not found" #2249
Solution
If a product has unpublished changes, they published state is in
products.__published. Use that for building the perma-link from
products.__published.handle.
Impact: major
Type: bugfix
Breaking changes
not known
Testing