Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to review/modify email templates #423

Closed
saralouhicks opened this issue Jul 21, 2015 · 18 comments
Closed

Ability to review/modify email templates #423

saralouhicks opened this issue Jul 21, 2015 · 18 comments
Assignees
Labels
epic For issues that exist only to track progress on a list of other issues in one place
Milestone

Comments

@saralouhicks
Copy link
Member

saralouhicks commented Jul 21, 2015

The following email templates are needed for Beta:

New user invite (admin)
Welcome (shopper)
Order complete (shopper)
Shipment notification (shopper)
Order status changes - refunds, delays, stage change (shopper)
Change PW (shopper)

@aaronjudd
Copy link
Contributor

@mikemurray @saralouhicks per discussion, this is the list of email template we need/have.

We currently don't send the order complete or welcome emails, the others are sent, but we need a good standard design template to use with these.

@aaronjudd
Copy link
Contributor

Templates will also need i18n handling. The current ones need updates as well for i18n in the sender fields on the server.

from: "shipping confitmation " + " <" + shop.emails[0].address + ">",

aaronjudd pushed a commit that referenced this issue Dec 12, 2015
Resolves #76
WIP for Issue #423
- updates reaction-collections
- updates reaction-schemas
@jshimko jshimko self-assigned this Jan 20, 2016
@aaronjudd
Copy link
Contributor

@saralouhicks we'll need some generic templates to add to the existing templates. (which have no layout).

@jshimko jshimko removed their assignment Jan 27, 2016
@aaronjudd aaronjudd added backlog and removed ready labels Mar 11, 2016
@aaronjudd aaronjudd modified the milestones: v0.13.0, v0.14.0 Mar 11, 2016
@prinzdezibel
Copy link
Contributor

i18n is addressed with PR #1062

@aaronjudd aaronjudd modified the milestones: v0.15.0 RC, v0.14.0 Jun 28, 2016
@aaronjudd aaronjudd added ready and removed backlog labels Jun 30, 2016
@brent-hoover
Copy link
Collaborator

So since this ticket was assigned to @rymorgan I am assuming this is the epic and covers doing the design UI of the templates in anticipation of implementation starting for 16?

@brent-hoover brent-hoover removed the ready label Aug 4, 2016
@HadenHiles
Copy link

Just wondering if someone can point me in the right direction as to how to override the order email templates using the Templates collection? I can't seem to find anything in the docs or otherwise.

Thanks!

@aaronjudd
Copy link
Contributor

@HadenHiles currently you can override by adding the html email content directly into the Templates collection.

@HadenHiles
Copy link

I noticed that in the email.js. I'm just not sure as to what the Templates collection should look like. Could you provide an example template object perhaps? I am branched off the development branch and there is no Templates collection with example data for me to reference, and I couldn't find any examples in the docs either.

Sorry if I missed something that already explains this with more detail, I wouldn't ask without doing my best to figure it out on my own. I even tried guessing the object structure but had no luck.

@jshimko
Copy link
Contributor

jshimko commented Sep 29, 2016

You can find the schema here:

https://github.com/reactioncommerce/reaction/blob/master/lib/collections/schemas/templates.js

So, to replace the welcome email, it might look something like:

import Templates from '/lib/collections';

Templates.insert({
  template: 'accounts/sendWelcomeEmail',
  language: 'en',
  source: 'the HTML or plain text content of your email'
});

(the language key being optional if you're adding an English email)

@HadenHiles
Copy link

Ah, thank you @jshimko!

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 29, 2016

The current Templates schema is https://github.com/reactioncommerce/reaction/blob/master/lib/collections/schemas/templates.js

We didn't really document that because we're also going to be updating it soon with a more flexible structure, see the proposed structure here: https://github.com/reactioncommerce/reaction-docs/compare/proposed-email-templates

The current Templates doesn't allow for header/subject,etc...

@HadenHiles
Copy link

Oh I see; why document something that is going to be updated and redundant. That makes sense.

Thanks again for the help, seems like you guys are really on your game. Keep it up!

@brent-hoover
Copy link
Collaborator

@saralouhicks @aaronjudd So the title of this ticket is about reviewing/editing the email templates however the body of the ticket is all about implementing the templates which is now in #1429. Do we want to keep this ticket for adding the ability to edit templates through the dashboard or start over with a new ticket?

@brent-hoover
Copy link
Collaborator

Since this ticket mostly addresses email templates which is covered in #1429 I am going to close this ticket. A new ticket for modifying/editing tickets through the dashboard should be created.

@brent-hoover
Copy link
Collaborator

This is the transactional email "epic". Reopening

@brent-hoover brent-hoover reopened this Oct 21, 2016
@brent-hoover brent-hoover added epic For issues that exist only to track progress on a list of other issues in one place and removed UIX labels Oct 21, 2016
@kieckhafer
Copy link
Member

Fixed by #1585

@mikemurray mikemurray removed the review label Dec 2, 2016
cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
…l-bronto-plugin

chore(email-bronto): update to 1.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic For issues that exist only to track progress on a list of other issues in one place
Projects
None yet
Development

No branches or pull requests

9 participants