Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more email templates #1585

Merged
merged 26 commits into from
Nov 22, 2016
Merged

more email templates #1585

merged 26 commits into from
Nov 22, 2016

Conversation

kieckhafer
Copy link
Member

Having issues with the last PR, so making a new one.

@kieckhafer kieckhafer changed the title [WIP] more email templates more email templates Nov 17, 2016
@kieckhafer
Copy link
Member Author

This, along with a few others, fixes #423, allowing email template editing in the dashboard.

@aaronjudd
Copy link
Contributor

@kieckhafer did you want name in the template editor to be editable? Wasn't this supposed to be disabled?

@aaronjudd
Copy link
Contributor

aaronjudd commented Nov 18, 2016

how would I create a new email template (say for another language), based on an existing one?
(or is that an enhancement?)

I also was able to get an empty update screen from the settings in the dashboard card, but the form is not functional.
dashboard_and_slack_-_reaction

Exception while invoking method 'templates/email/update' Error: Match error: Expected string, got null

@brent-hoover
Copy link
Collaborator

Seeing this error in the server console after placing an order

03:08:52.788Z ERROR Reaction: Error in orders/sendNotification for order W2BGyczBMJoqQ9egH
  Error: Access Denied [403]
      at [object Object].ordersRefundsList (server/methods/core/orders.js:857:13)
      at packages/check.js:130:16
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:129:41)
      at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1709:18)
      at packages/ddp-server/livedata_server.js:1625:18
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at Server.apply (packages/ddp-server/livedata_server.js:1624:45)
      at Server.call (packages/ddp-server/livedata_server.js:1567:17)
      at packages/kadira:flow-router-ssr/server/plugins/ssr_data.js:67:23
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at Object.Meteor.(anonymous function) [as call] (packages/kadira:flow-router-ssr/server/plugins/ssr_data.js:66:44)
      at [object Object].ordersSendNotification (server/methods/core/orders.js:390:33)
      at packages/check.js:130:16
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:129:41)
      at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1709:18)
      at packages/ddp-server/livedata_server.js:1625:18
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at Server.apply (packages/ddp-server/livedata_server.js:1624:45)
      at Server.call (packages/ddp-server/livedata_server.js:1567:17)
      at packages/kadira:flow-router-ssr/server/plugins/ssr_data.js:67:23

@brent-hoover
Copy link
Collaborator

When editing a template and hitting "Update", I am getting an error saying the name field is missing even though it's right there.

templates

@aaronjudd aaronjudd merged commit e2d11a0 into release-0.18.0 Nov 22, 2016
@aaronjudd aaronjudd removed the review label Nov 22, 2016
@aaronjudd
Copy link
Contributor

👍 @kieckhafer need to track the remaining couple of issues needing cleanup..

  • adding new templates
  • form validation on template editor

@aaronjudd aaronjudd deleted the ek-more-emails branch November 22, 2016 22:22
@kieckhafer kieckhafer mentioned this pull request Dec 2, 2016
@kieckhafer kieckhafer restored the ek-more-emails branch February 8, 2017 05:47
@kieckhafer kieckhafer deleted the ek-more-emails branch February 23, 2017 18:48
@spencern spencern mentioned this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants