Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.15.1 #1323

Merged
merged 31 commits into from
Aug 23, 2016
Merged

Release 0.15.1 #1323

merged 31 commits into from
Aug 23, 2016

Conversation

kieckhafer
Copy link
Member

  • Meteor 1.4.1
  • native implementation bcrypt (meteor npm install --save bcrypt)
  • update eslint-2 note
  • add .bithoundrc & more bitHound rules
  • update to eslint-3
  • linting updates (updated rules, enforced constant preferences, update consistent-return rule, use strict: 0 per babel-eslint, warn if not valid-jsdoc, warn on max-len, allowImportExportEverywhere for Meteor’s reify conditional imports, warn on prefer-const)
  • updated READAME.md
  • disable & remove CodeClimate
  • add jquery ignore unused
  • add app-test to test scoring (http://blog.bithound.io/scoring-test-files-in-bithound/)
  • guard for in loop
  • updated var assignments (const / let)
  • update imports
  • updated for testing (methods updates to pass testing)
  • updated fast-render
  • updated sweetAlert (fix error “message unknown parameter” from sweetAlert)
  • update core label, description
  • updated README.md (add CC badge back until we can pass on warnings from BitHound)
  • updated packages (move newly added shell-server to “meteor” packages)

jshimko and others added 30 commits August 3, 2016 18:25
* rebuild launchdock-connect as a plugin module

* build more flexible admin email verification method

* add Stripe dependency for launchdock-connect

* fix linting issues
* Trap order-completed change

* Add missing import

* Add cartItemId field to order so that we can modify inventory

* Add new "inventory/sold" method

* Explicitly set from and to statuses

* Handle order insert hook to move ordered inventory to "sold" status

* Handle moving inventory from "reserved" to "sold" status

* Fix email import

* Fix tests

* Not so much logging

* Call status change method with explicit values

* Add test for moving inventory from "reserved" to "sold"

* Add test for moving inventory from "sold" to "shipped"
* Force eslint to recognize that swtich/case should be indented
eslint/eslint#1797

* remove eslint-plugin-meteor

- we need to tune this, removing until we have time

* enable eslint-2 codeclimate

- remove meteor-eslint plugin, failing to load with eslint-2

* updated switch indentation

- test eslint switch, case indent
* build initial implementation of route hooks

* extend Router with Hooks and register all hooks

* more route hooks tweaks

* router namespace cleanup

* removed unused values from registry entry (linter)
* As noted in comments from previous PR, just some reorg kept separate from the functionality PR

* Correct matching
* Add failing test

* Fix for update Mongo command

* Add failing test for "decrease below zero"

* If removeQuantity is more than quantity remove the entire line

* updated linting error

* linting error fix

* listing issues

* more cleanup and linting tweaks

* fix eslint config for object key quotes

* fix tests after error message update

* revert quote-props linter change

* revert lint changes

* Simplify logic per CR comment
- fixes error .names undefined
- for loading tz in i18n settings
* Reduce size of the cart so that orders don't take so long to process.

* Add a wait before pulling record

* Add a wait before pulling record

* Wait after calling Meteor method

* Longer timeout

* Longer timeout
* update circle node to v4.4.7

* remove unused packages

- remove eslint-plugin-meteor
- remove bunyan-loggly (insecure dependency)
- currently not in use
- updates jquery-i18next
- updates i18next-browser-languagedetector
* build job queue for email and refactor related methods

* put placeholder content in coreDefault email template

* add rate limiting for accounts and notification methods

* put order completed template at correct path

* update old jquery-i18next

* remove log

* remove unused var

* remove unnecessary filler in placeholder template

* log warning when email template isn’t found

* return job object from Reaction.Email.send()

* fix missing import

* fix comment for email method

* remove debugging logger

* updated to remove name from email

should be enough info
* updated hasPermissions, router behaviour

- resolves #1122
- refactors client hasPermissions to wait for a userId if one isn’t
immediately found
- intentionally not redirecting to home page (not sure if that’s the
best behavior, better to have login?)
- adds subscription manager to a few more collections

* fix typo

* import lodash

might work better if _.find exists

* check for existing route table
* allow discounts and refunds with PayPal PayFlow

- Fix discounts so they are working
- Allow 100% discounts
- Fix refunds so they are working

* wrap PayPal PayFlow in wrapper for easier testing

* PayPal PayFlow refund test

* removed temporary file

* updated cc error message
cardNumber schemas were not allowing valid credit cards, such as Amex
(15 digits), some Visa (13 digits), and foreign Maestro (12 - 19
digits). This updates to allow these lengths to be input.
* don’t run bash scripts in postinstall because Windows

* add fallback fonts back to public dir

* release 0.15.0

- updated package in preparation for new release
…oducts (#1263)

* - ignoring my custom entrypoint (for running prod image with src)

* - allow users with createProduct permission to delete products (for marketplace withmultiple sellers)

* - removing .gitignore files that is not welcome in repo
* add Braintree Payment error to en.json

* enable discounts for Braintree payments

Braintree was not capturing discounts, instead using the amount in the
original authorization for the capturing. This update changes the
amount to the paymentMethod.amount, which includes discounts.

* removed else statement after an if containing a return

Since the return inside the IF statement will effectively kill the
process if it’s hit, there is no need for the else.

* added testing for Braintree refunds

This code still needs some love, just wanted to get it up for others to
take a look at.

* remove no longer needed commented code

* remove no longer needed commented code

* added field to expected response for testing

* moved braintree/refund/list methods into BraintreeApi wrapper

Creating a wrapper for Braintree in order to more easily perform testing

* move braintree methods into new file

* reconfigure all braintree payment code to no longer use ValidateMethod

* fixed lint issues

* removed code used to skip over 24 hour braintree delay (for testing)

* Rename braintreeapi.js to braintreeApi.js

* display absolute number of adjustedTotal

due to various instances of rounding numbers for display purposes, the
adjustedTotal would sometimes display -0.00, as the adjusted total was
technically -.00000000000000000000001, even though we display 0.00 when
we round it. This update just shows the absolute number, as this is
simple a display number and does not have any affect on what is being
sent to and from the payment provider.

* updated schema to match supported payment methods

The current Schema had a 16 number minimum for credit cards, however
braintree supports cards which have number lengths ranging from 12-19

* min -> max

* removed comments

* test testing

* update braintree test

* update exports of braintreeApi functions

* fixed callback error when action has no callback

* Updated error message to make more sense to a human user

* linter fixes

* updated 'Logger.info' to Logger.debug

* removed unused test

* removed commented callback

* don't log full order details on transaction error
- Fix discounts so that they are correctly sent to authorize.net

- Allow 100% discounts by adding the “voidTransaction” function and
voiding transactions

- Update error messaging for Refunds, as we do not (yet) allow them
from Authorize.net
* added comment to explain voiding vs applying discount

* add ___ for correctly calculating Stripe adjusted totals

Stripe doesn’t “do” discounts, instead they take the discount sent to
them, and apply it as a refund. This was causing any discounts to show
up twice - once as a discount, once as a refund - in our adjusted
total. This update fixes that by re-adding the discount price into the
adjusted total when the payment provider is Stripe.

* also 100% discounts on Stripe

* humanizing an error code

* removed unintentional text

* linting fixes

* removed unused commented code

* removed unused commented code
* initial commit tax-rebase plugin

Initial commit for issue #972

* split providers to plugins/included

* Griddle updates

- fork MeteorGriddle into core/ui-grid
- move fetchTI
- add i18n taxSettings

* initial grid editing

* add taxSettings labels

* initial custom add / edit tax rates

- initial working forms, edit toggling.. bit rough..

* rename tax-base to taxes

* updated custom grid

 - adds row selection

* add custom rate form reset

* updated custom settings

* add cart hooks to trigger taxes/calculate

* update hooks, taxes/deleteRate

- also adds taxes/deleteRate

* migrate schemas to plugins

- also set taxCloud jobs to not run by default

* add custom tax rates calculation

- add taxes, tax to cart schema
- taxes not published to client
- updates global cartTotal helpers

* check for shipping

* migrate settings to plugins

* add tax hooks to plugins

 -abort idea on “provides” as a package property

* Avalara Tax Lookup

 - adds taxes/setRate method

* comment unused fields

- comment out first implementation unused fields

These are fields that will be used future enhancements to taxes.  They
are commented out for now.

* logger cleanup

- move info to debug

* updated product data with default taxable items

- add taxCode placeholder to schema

* taxCloud tax rate calculations

* disable taxjar, check for packages

- disable while module is not functional
- WIP fetch rates and api configuration

* custom rate ui cleanup

* taxes method test

- a weak attempt at a test but gets the ball rolling and actually fixes
a todo

* updated test, versions

- add done to test
- updated meteor package versions

* remove unused template registry entries

- final cleanup, ready for PR to development
- pending tests
- pending docs

* avoid running country-data unless address exists

* add tax rate delete

- adds delete and confirm to edit form

* linted griddle.js

* remove unused import

* fix display of taxes in order workflow

perhaps this should be updated to “tax”, instead of taxes in the
invoice object.

* line item calculations

- added for custom rates
- added for avalara

rates are calculated by individual line items but on a general rate for
the cart.

* update case linted

* updated variant methods

- update products/updateProductField to handle boolean
- kludge update of childVariants when parentVariant is updated
- remove default value from form
- small cleanups
* updated various sortable lists that used jquery-ui

Removed dependency on jquery-ui from sortable lists, product grid,
gallery, variant-list. Switched to sortable.js.

* added git ignore entry for config file

* Removed dependency on jquery-ui autocomplete

Replaced jquery-ui autocomplete for a react based autocomplete
component.

* Removed jquery-ui

* fixed some eslint issues

* added translation for update tag

* fixing duplicate code eslint issue

* updated i18n default value key

* fix auto suggesst clipping and text issues in navbar

* Fix cart panel slide out animation

* fix z-index issues with cart slide in and action view
* Fix wrong method hooks context

Fix passing the wrong context into before and after method hooks

* Using 'this' and arrow functions instead of 'self'
* Meteor 1.4.1

* release 0.15.1

* native implementation bcrypt

meteor npm install --save bcrypt

* update eslint-2 note

* add .bithoundrc

* update to eslint-3

* linting updates

* updated READAME.md

release 0.15.1
remove CodeClimate
add more bitHound

* disable code climate

- would like one full cycle through master before removing.

* remove failing rule

* updated rules

* linted schema

* enforce constant preferences

- eslint fixes
- enforces a preference that we use const as the default, which should
make it clear if there are any stray bugs caused by unexpected variable
assignments.

* update dev eslint-plugin-react

* update consistent-return rule

- warn instead of error
- use strict: 0 per babel-eslint docs

* add jquery ignore unused

* add app-test to test scoring

http://blog.bithound.io/scoring-test-files-in-bithound/

* guard for in loop

* updated var assignments

```
   80:3  error  'filter' is never reassigned. Use 'const' instead
     prefer-const
   81:3  error  'registryFilter' is never reassigned. Use 'const'
instead    prefer-const
   99:3  error  'fields' is never reassigned. Use 'const' instead
     prefer-const
  107:3  error  'reactionPackages' is never reassigned. Use 'const'
instead  prefer-const
```

* update var assign, return

```
   30:62  warning  Expected to return a value at the end of this
function  consistent-return
  244:3   error    'result' is never reassigned. Use 'const' instead
   prefer-const
  263:3   error    'nl2br' is never reassigned. Use 'const' instead
   prefer-const
```

* update imports

-   `4:10  error  'Session' is defined but never used  no-unused-vars`
- updated safestring method, I didn’t see where else we’re using
Handlebars and I believe these are synonymous, (and we’re using
Spacebars elsewhere).

* warn if not valid-jsdoc

* enforce lint rules

- add TODO, set warning, where further review is needed.

* updated eslint rules

 - warn on max-len
- allowImportExportEverywhere for Meteor’s reify conditional imports
- warn on prefer-const

* updated for testing

- methods updates to pass testing
- needs more testing of results

* updated fast-render

* updated sweetAlert

 - fix error “message unknown parameter” from sweetAlert

* update core label, description

- a change that has been made a few times, hopefully sticks around this
time.

* updated README.md

- add CC badge back until we can pass on warnings from BitHound

* updated packages

- move newly added shell-server to “meteor” packages
@jshimko
Copy link
Contributor

jshimko commented Aug 23, 2016

👍

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants