Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Concurrent Mode Adoption #323

Merged
merged 5 commits into from
Nov 21, 2019

Conversation

Paynekk
Copy link
Contributor

@Paynekk Paynekk commented Nov 19, 2019

I have already uploaded a PR. It is the first time I contribute and I hope to continue doing so. 😃 ✳️
@carburo
References #316
Closes #313

@netlify
Copy link

netlify bot commented Nov 19, 2019

Deploy preview for es-reactjs ready!

Built with commit 25a79dc

https://deploy-preview-323--es-reactjs.netlify.com

@Paynekk Paynekk force-pushed the concurrent-mode-adoption branch from 561c428 to 9bcfffa Compare November 19, 2019 02:41
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you so much for your contribution.
I just made some comments about a couple of minor issues. Feel free to reply if you don't agree or don't understand the suggestion.

@Paynekk
Copy link
Contributor Author

Paynekk commented Nov 21, 2019

@carburo thank you very much for the review! I made your suggestions :) 😃

@carburo carburo self-requested a review November 21, 2019 19:52
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Mezclado! 🚀
¡Muchas gracias nuevamente!

@carburo carburo merged commit 13684d1 into reactjs:master Nov 21, 2019
@Paynekk Paynekk deleted the concurrent-mode-adoption branch November 21, 2019 20:05
@carburo carburo mentioned this pull request Nov 21, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants