translate reference react dom server document #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurau4
force-pushed
the
translate/react-dom-server
branch
from
74812b1 to
2a8066d
Compare
90 tasks
|
Deploy preview for ja-reactjs ready! Built with commit 3668084 |
|
@potato4d レビューありがとうございます 🙏 |
koba04
reviewed
Feb 21, 2019
| @@ -79,14 +79,14 @@ If you call [`ReactDOM.hydrate()`](/docs/react-dom.html#hydrate) on a node that | |||
| ReactDOMServer.renderToStaticNodeStream(element) | |||
| ``` | |||
|
|
|||
| Similar to [`renderToNodeStream`](#rendertonodestream), except this doesn't create extra DOM attributes that React uses internally, such as `data-reactroot`. This is useful if you want to use React as a simple static page generator, as stripping away the extra attributes can save some bytes. | |||
| React が内部的に使用する `data-reactroot` のような追加の DOM 属性を作成しないことを除いて、[`renderToNodeStream`](#rendertonodestream) と同様の動作をします。このメソッドはシンプルな静的ページを生成するのに React を使用したい場合に便利で、追加の属性を省略することでバイト数を削減できます。 | |||
There was a problem hiding this comment.
simpleはgeneratorに掛っていると思ったので言い回しを調整してみましたが如何でしょうか？
Suggested change
| React が内部的に使用する `data-reactroot` のような追加の DOM 属性を作成しないことを除いて、[`renderToNodeStream`](#rendertonodestream) と同様の動作をします。このメソッドはシンプルな静的ページを生成するのに React を使用したい場合に便利で、追加の属性を省略することでバイト数を削減できます。 | |
| React が内部的に使用する `data-reactroot` のような追加の DOM 属性を作成しないことを除いて、[`renderToNodeStream`](#rendertonodestream) と同様の動作をします。このメソッドは単純な静的ページジェネレーターとして React を使用したい場合に便利で、追加の属性を省略することでバイト数を削減できます。 |
There was a problem hiding this comment.
前回、potato4dさんから入った指摘を修正忘れていたのに気づいたので、それに沿ってfixしました 👍
|
@koba04 レビューありがとうございます！ IMO、取り込ませていただきました 👍 |
koba04
approved these changes
Feb 23, 2019
|
@sasurau4 mergeしました 🚀🚀🚀 ありがとうございます！ 🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #4
とりあえず、
renderは変換で訳してみましたレビューお願いします 🙏