Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate shallow-renderer #56

Merged
merged 11 commits into from
Feb 7, 2019
Merged

Translate shallow-renderer #56

merged 11 commits into from
Feb 7, 2019

Conversation

sakit0
Copy link
Contributor

@sakit0 sakit0 commented Feb 3, 2019

Translate shallow-renderer

issue : #4

Please review.

@smikitky
Copy link
Member

smikitky commented Feb 4, 2019

レビューは後になりますが、とりあえず render は「レンダー」ですが renderer は「レンダラ」でお願いします。タイトルの Shallow Renderer についてもアルファベットのままで残していいと思していいと思います。

@koba04 koba04 requested review from koba04 and removed request for koba04 February 4, 2019 01:18
@sakit0
Copy link
Contributor Author

sakit0 commented Feb 4, 2019

@smikitky
個人的に訳し過ぎていたと思う部分を修正しました🙏
8a27fd0

@tesseralis tesseralis mentioned this pull request Feb 5, 2019
Closed
90 tasks
smikitky
smikitky requested changes Feb 5, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 少しだけ日本語に戻しました
  • あとはスペースなど微修正です

@koba04 koba04 mentioned this pull request Feb 6, 2019
Merged
koba04
koba04 requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakito21 一点だけ表記の確認お願いします 🙏

@koba04 koba04 merged commit 81db23d into reactjs:master Feb 7, 2019
@koba04
Copy link
Member

koba04 commented Feb 7, 2019

@sakito21 ありがとうございます！マージしました 🚀🚀🚀

@sakit0 sakit0 deleted the ShallowRenderer-ja branch February 8, 2019 03:27
@sakit0
Copy link
Contributor Author

sakit0 commented Feb 8, 2019 •
edited
Loading

@koba04 @smikitky @takanorip ありがとうございました！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip left review comments

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sakit0 @smikitky @koba04 @takanorip