-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate "unmountComponentAtNode" #660
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: wronge styles when applying RTL it was `top-0 left-0 ...` by wrong I made it `inset-x-0`. * fix wrong styles * fix wrong styles * style canary icon with RTL-friendly styles * chore: utilize mx-* instead of me-* & ms-* * utilize relative styles * chore: use mx-* instead of me-* & ms-* * style canary icon with RTL-frindly styles * Update OpenInTypeScriptPlayground.tsx
Co-authored-by: Luna Wei <[email protected]>
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Translate "Common Components (e.g., <div>)"
Finish sidebar translations
React attends this conference hosted by Callstack. It's been on the page in previous years, missed it this year. https://www.react-native.eu/
* Translate createContext * fix some styles * fix translations * fix quote style * Restore link that was accidentally removed * Restore more links * Fix capitalization problems --------- Co-authored-by: Soichiro Miki <[email protected]>
Fix top page layout
* Translate "useReducer" * fix: Unify the terminology * fix: Tweak translations
* Translate "<select>" component * Fix translations * Props => props * プロパティ => props * 微修正 * Fix markup issue --------- Co-authored-by: Soichiro Miki <[email protected]>
* Complete translation * Update translation to match other pages * Update src/content/reference/react-dom/components/input.md --------- Co-authored-by: Soichiro Miki <[email protected]> Co-authored-by: Toru Kobayashi <[email protected]>
Sync with react.dev @ 3189529
Translate SNS card images
Translate "createPortal"
Translate "<textarea>" reference
Translate "flushSync" reference
fix link [add interactivity to existing HTML pages]
* chatgpt translation and textlint * fix translation * fix after review * fix * Apply suggestions from code review * Small tweak for consistency --------- Co-authored-by: Soichiro Miki <[email protected]>
Sync with react.dev @ 722b546
Translate "renderTo{Readable|Pipable}Stream"
Translate four reactdom/server render methods
Translate react-dom server API index
koba04
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!!!
Co-authored-by: Toru Kobayashi <[email protected]>
Translate "Using TypeScript"
Translate "unmountComponentAtNode"
なんか妙なことが起きてGitHubのウェブUI上はマージが失敗したという表示になっているみたいですが、コミットグラフ上は正しいようなのでこのまま様子を見ます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.