Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new prop-types package #171

Closed
oliviertassinari opened this issue Apr 8, 2017 · 2 comments · Fixed by #172
Closed

support new prop-types package #171

oliviertassinari opened this issue Apr 8, 2017 · 2 comments · Fixed by #172

Comments

@oliviertassinari
Copy link

Yesterday's announcement includes a deprecation of React.PropTypes and an introduction of a new package prop-types.
That's change introduce breaking changes here, for instance, the required value is no longer correct.

@kazazor
Copy link

kazazor commented Apr 9, 2017

We're also seeing issues due to that. For example we're now getting this output:

prop type default required description
children (custom validator) The components's children
className (custom validator) A custom CSS class name
disabled (custom validator) Whether the anchor is clickable or not
hovered (custom validator) Whether the button is in hover state
onClick (custom validator) A callback function for click event

While we used to get:

prop type default required description
children ReactNode The components's children
className String A custom CSS class name
disabled Boolean Whether the anchor is clickable or not
hovered Boolean Whether the button is in hover state
onClick Function A callback function for click event

So it's the Required & the type that does not work.

@fkling
Copy link
Member

fkling commented Apr 13, 2017

Publish in v2.14.0 and v3.0.0-beta3.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants