Merge pull request #8 from yangshun/constructor-props

Ensure all class constructors call super with props
reactjs · Oct 7, 2017 · 463640d · 463640d
2 parents 6c19b64 + 7c6f185
commit 463640d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/content/blog/2015-01-27-react-v0.13.0-beta-1.md b/content/blog/2015-01-27-react-v0.13.0-beta-1.md
@@ -89,8 +89,8 @@ Therefore we decided not to have this built-in into React's class model. You can
 
 ```javascript
 class Counter extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.tick = this.tick.bind(this);
   }
   tick() {

diff --git a/content/docs/higher-order-components.md b/content/docs/higher-order-components.md
@@ -30,8 +30,8 @@ For example, say you have a `CommentList` component that subscribes to an extern
 
 ```js
 class CommentList extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.handleChange = this.handleChange.bind(this);
     this.state = {
       // "DataSource" is some global data source

diff --git a/content/tutorial/tutorial.md b/content/tutorial/tutorial.md
@@ -200,8 +200,8 @@ First, add a constructor to the class to initialize the state:
 
 ```javascript{2-7}
 class Square extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       value: null,
     };
@@ -228,8 +228,8 @@ Now the `<button>` tag looks like this:
 
 ```javascript{10-12}
 class Square extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       value: null,
     };
@@ -282,8 +282,8 @@ Pulling state upwards like this is common when refactoring React components, so
 
 ```javascript{2-7}
 class Board extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       squares: Array(9).fill(null),
     };
@@ -399,8 +399,8 @@ Try clicking a square – you should get an error because we haven't defined `ha
 
 ```javascript{9-13}
 class Board extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       squares: Array(9).fill(null),
     };
@@ -528,8 +528,8 @@ Let's default the first move to be by 'X'. Modify our starting state in our Boar
 
 ```javascript{6}
 class Board extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       squares: Array(9).fill(null),
       xIsNext: true,
@@ -564,8 +564,8 @@ After these changes you should have this Board component:
 
 ```javascript{6,11-16,29}
 class Board extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       squares: Array(9).fill(null),
       xIsNext: true,
@@ -715,8 +715,8 @@ First, set up the initial state for Game by adding a constructor to it:
 
 ```javascript{2-10}
 class Game extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       history: [{
         squares: Array(9).fill(null),
@@ -1006,8 +1006,8 @@ First, add `stepNumber: 0` to the initial state in Game's `constructor`:
 
 ```js{8}
 class Game extends React.Component {
-  constructor() {
-    super();
+  constructor(props) {
+    super(props);
     this.state = {
       history: [{
         squares: Array(9).fill(null),