Ensure all class constructors call super with props #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 7c6f185 |
bvaughn
approved these changes
Oct 7, 2017
There was a problem hiding this comment.
It's not strictly necessary since we explicitly set props on the instance after construction (in case people forget to pass them to the super constructor) but it is good to show this in the docs. 👍
Closed
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
* Update reference-javascript-environment-requirements.md * Corrigido links para o MDN * modifications * Improved/Fixed some translations.
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
* docs(cn): add `Thinking in React` translations * docs(cn): add translation for `mock` * docs(cn): modify phrasing in regard to review suggestions * docs(cn): changes regarding review feedback * docs(cn): rephrase some words & remove control characters * docs(cn): revert Wikipedia links to English version * docs(cn): changes for overall smoothness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether it is strictly necessary for "Class components should always call the base constructor with props", but it is mentioned here so I think this should be enforced in the documentation at the very least.