Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification: auto-dismiss #366

Closed
humitos opened this issue Aug 19, 2024 · 0 comments · Fixed by #375
Closed

Notification: auto-dismiss #366

humitos opened this issue Aug 19, 2024 · 0 comments · Fixed by #375
Assignees
@humitos @zanderle
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Aug 19, 2024

Ideally, it should have the following features:

  • Using the page visibility API allows us to dismiss the notification only if the tab is in view.
  • Pausing the dismiss timer on mouse hover allows for reading of the text and clicking links.
  • Visual feedback on the timer helps readability too

Ideas grabbed from #46 (comment)
@humitos humitos added the Improvement Minor improvement to code label Aug 19, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Aug 19, 2024
humitos added a commit that referenced this issue Sep 18, 2024
@humitos
Notification: auto-dismiss while visible
1078bbf 
It detects if the tab is opened and trigger a timeout for 5 seconds. After that
time, the notification is hidden.

Eventually, we could use some nice effect, like fade out and stop the timer
while the pointer is over the notification -- but that't outside the scope of
this initial work.

Closes #366
@humitos humitos mentioned this issue Sep 18, 2024
Merged
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Sep 18, 2024
@humitos humitos self-assigned this Sep 18, 2024
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

@zanderle zanderle

Labels
Improvement Minor improvement to code
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notification: auto-dismiss while visible readthedocs/addons
2 participants
@humitos @zanderle