Notification: auto-dismiss while visible #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It detects if the tab is opened and trigger a timeout for 5 seconds. After that time, the notification is hidden. Eventually, we could use some nice effect, like fade out and stop the timer while the pointer is over the notification -- but that't outside the scope of this initial work. Closes #366
agjohnson
approved these changes
Sep 18, 2024
|
I'll try something tomorrow. I'd like to not reset the time, but pause it. I may need to save the countdown time for that... Not sure how yet |
|
Either works, but resetting seems fine and doesn't require more state tracking. To make a notification that can be paused you could turn the timer into a 1s timer and accumulate a count of seconds unpaused instead. |
agjohnson
reviewed
Sep 19, 2024
Comment on lines
+82
to
+91
| _handleMouseEnter = (e) => { | ||
| // Stop the timer when notification is hovered (mouseenter event) | ||
| clearTimeout(this.timerID); | ||
| this.timerID = null; | ||
| }; | ||
|
|
||
| _handleMouseLeave = (e) => { | ||
| // Start the timer when the notification is hovered away (mouseleave) | ||
| this.triggerAutoDismissTimer(); | ||
| }; |
There was a problem hiding this comment.
@humitos Note, this doesn't handles the focusin/focusout events I mentioned. These are required for keyboard and screen reader support, which won't fire mouse events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It detects if the tab is opened and trigger a timeout for 5 seconds. After that time, the notification is hidden.
Eventually, we could use some nice effect, like fade out and stop the timer while the pointer is over the notification -- but that't outside the scope of this initial work.
Closes #366