[DX] Deprecate NonPhpRectorInterface, the only rule and its file processor, to make Rector handle exlusively PHP #4761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rector as any other tools like ECS, PHPStan, PHP-CS-Fixer, PHPUnit, Pest etc. focuses on working with PHP files.
Yet, in some cases it can change yaml, twig or latte files too. While using PHP classes in templates is a bad practise, it cannot be avoided like in Symfony configs.
That's why added a "special file processor" that was able to handle some non-php files too. This is not-so-known feature, that works in a magic way:
This magic is hidden deep and it leads to unnexpected cases, that some class are renamed and some not.
Instead these files should be skipped completely and Rector handle PHP files only. This will show same behavior as other CLI tools mention above and make you handle non-PHP files yourself in consistent way 👍
That's why I've decided to remove this magic feature before going Rector 1.0 stable