Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning for FileProcessorInterface #4808

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add deprecation warning for FileProcessorInterface #4808

merged 1 commit into from
Aug 17, 2023

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 17, 2023 •
edited
Loading

Follow up to NonPhpRectorInterface deprecation, as we aim for PHP file processor now:
#4761

@TomasVotruba TomasVotruba force-pushed the tv-inform-about-file-processor branch 2 times, most recently from 07461f8 to f58289b Compare August 17, 2023 12:43
@TomasVotruba TomasVotruba force-pushed the tv-inform-about-file-processor branch from 42e52b1 to cb47563 Compare August 17, 2023 12:46
@TomasVotruba TomasVotruba changed the title Add deprecation warning of FileProcessorInterface Add deprecation warning for FileProcessorInterface Aug 17, 2023
@samsonasik
Copy link
Member

/cc @sabbelasichon FYI

@TomasVotruba TomasVotruba merged commit 7303254 into main Aug 17, 2023
@TomasVotruba TomasVotruba deleted the tv-inform-about-file-processor branch August 17, 2023 12:49
@TomasVotruba
Copy link
Member Author

Here is the full Github search for active projects that use the file processor - 2 projects in total:

https://github.com/search?q=%22use+Rector%5CCore%5CContract%5CProcessor%5CFileProcessorInterface%22++language%3APHP+language%3APHP++NOT+is%3Afork+-org%3Arectorphp+-org%3Adeprecated-packages+-org%3Aefabrica-team&type=code&ref=advsearch

@samsonasik
Copy link
Member

/cc @skurfuerst FYI

@skurfuerst
Copy link

Oh thanks for notifying me - that's a pity because it worked so well :) but we will figure something out.

@TomasVotruba
Copy link
Member Author

@skurfuerst Thanks for understanding 🙏

This post shared few reasons behind focusing on solely PHP: https://getrector.com/blog/rector-018-refocus-on-php

@dlubitz dlubitz mentioned this pull request May 3, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasVotruba @samsonasik @skurfuerst