Add feature to tag image with multiple tags #21
Conversation
divyansh42
force-pushed
the
issue-20
branch
3 times, most recently
from
a0fc441 to
cc7e1fd
Compare
Signed-off-by: divyansh42 <[email protected]>
divyansh42
force-pushed
the
issue-20
branch
3 times, most recently
from
6aaea1f to
c10339c
Compare
Signed-off-by: divyansh42 <[email protected]>
|
I notice this action is still missing the eslint and action-io-generator CI checks. I would love to put our 3 CI checks into a composite action so we can reuse them more easily. Once this and the matching push-to-registry PR are in we can think about that. |
Yeah, I have planned to add CI checks in a seperate PR, but it will be great if we can have a composite action for this. |
Signed-off-by: divyansh42 <[email protected]>
Signed-off-by: divyansh42 <[email protected]>
Signed-off-by: divyansh42 <[email protected]>
| (acc, line) => acc.concat(line).map(pat => pat.trim()), | ||
| [] | ||
| .split(/\r?\n/) | ||
| .filter((x) => x) |
There was a problem hiding this comment.
We don't have to change this right now but this filter call does nothing and should be removed
| [] | ||
| .split(/\r?\n/) | ||
| .filter((x) => x) | ||
| .reduce<string[]>( |
There was a problem hiding this comment.
this reduce also looks like it should be a map. it's not doing any flattening, just trimming each item
Fixes: #20
Signed-off-by: divyansh42 [email protected]