feat(prettier) upgrade to prettier v3 #10179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
commented
Mar 9, 2024
| @@ -54,7 +54,6 @@ | |||
| "@types/fs-extra": "11.0.4", | |||
| "@types/jest": "29.5.8", | |||
| "@types/jscodeshift": "0.11.6", | |||
| "@types/prettier": "2.7.3", | |||
There was a problem hiding this comment.
Prettier provides its own types now. See the deprecation warning on https://www.npmjs.com/package/@types/prettier.
Josh-Walker-GM
approved these changes
Mar 9, 2024
jtoar
added
fixture-ok
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
Second attempt of #9077 now that Jest tests are holding us back thanks to @Josh-Walker-GM! 🚀 I've also included the changes in #9078. I'm pretty sure this isn't breaking but will be more thorough after CI passes.
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
@Josh-Walker-GM pointed out some breaking changes I included in the prettier v3 upgrade (#10179) in his PR [here](#10183). My goal with the prettier v3 upgrade was to first do it in a non-breaking way so that it could be released in the next minor, then come back and include the breaking changes (mainly around the tailwind setup command). This should undo the breaking changes so that we can release prettier v3 in the next minor and redo #10182.
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
@Josh-Walker-GM pointed out some breaking changes I included in the prettier v3 upgrade (#10179) in his PR [here](#10183). My goal with the prettier v3 upgrade was to first do it in a non-breaking way so that it could be released in the next minor, then come back and include the breaking changes (mainly around the tailwind setup command). This should undo the breaking changes so that we can release prettier v3 in the next minor and redo #10182.
jtoar
added
release:breaking
Josh-Walker-GM
added a commit
that referenced
this pull request
Apr 19, 2024
**Problem** This follows up on the work done in #10179. The prettier API is now async. Most of our code was already awaiting but we must now add `await` in several places we previously did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt of #9077 now that Jest tests aren't holding us back thanks to @Josh-Walker-GM! 🚀
I've also included the changes in #9078. I'm pretty sure this isn't breaking but will be more thorough after CI passes.