fix: fully resolves Tailwind setup command failing due to Prettier v3 dependency #9078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidprice
commented
Aug 27, 2023
| @@ -25,7 +25,7 @@ | |||
| "autoprefixer": "^10.4.14", | |||
| "postcss": "^8.4.27", | |||
| "postcss-loader": "^7.3.3", | |||
| "prettier-plugin-tailwindcss": "0.4.1", | |||
| "prettier-plugin-tailwindcss": "^0.4.1", | |||
There was a problem hiding this comment.
This needs to be updated. Recommend fully re-running update test-project command.
|
@jtoar I need to pass this off to you for future handling. Thanks in advance! |
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
Second attempt of #9077 now that Jest tests are holding us back thanks to @Josh-Walker-GM! 🚀 I've also included the changes in #9078. I'm pretty sure this isn't breaking but will be more thorough after CI passes.
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
Second attempt of #9077 now that Jest tests are holding us back thanks to @Josh-Walker-GM! 🚀 I've also included the changes in #9078. I'm pretty sure this isn't breaking but will be more thorough after CI passes.
|
We're now on Prettier v3 and prettier-plugin-tailwindcss v0.5 so this PR isn't relevant anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9075 (this is the full resolution; previously workaround)
Dependencies
fixtures/test-projectand confirmprettier-plugin-tailwindcssat latest and working correctly (0.4.1 is currently hardcoded and must be updated)