Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router tests: More advanced auth mock #5742

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 11, 2022

Make it configurable how long auth is in loading state (in our unit tests)

@jtoar I think this is a worthwhile improvement to our router test regardless of #5739

@netlify
Copy link

netlify bot commented Jun 11, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 358dc83
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62b84cdcff4d0f000963084d

@Tobbe Tobbe force-pushed the tobbe-router-whileloadingauth-hook branch from af20509 to f6e2b3f Compare June 11, 2022 09:11
@Tobbe Tobbe requested a review from jtoar June 11, 2022 09:15
@Tobbe Tobbe added the release:feature This PR introduces a new feature label Jun 11, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtoar jtoar enabled auto-merge (squash) June 26, 2022 12:11
@jtoar jtoar merged commit 151d89e into redwoodjs:main Jun 26, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 26, 2022
dac09 added a commit that referenced this pull request Jun 27, 2022
…b-issue-forms

* 'main' of github.com:redwoodjs/redwood: (40 commits)
  Update link to auth/providers implementations (#5826)
  fix(deps): update dependency qs to v6.11.0 (#5836)
  Docs -> Tutorial - Update comment-form.md - Minor Typo (#5837)
  fix: have user config for `addons` and `stories` take precedence (#5780)
  chore(deps): update dependency @tsconfig/docusaurus to v1.0.6 (#5834)
  chore(deps): update dependency @auth0/auth0-spa-js to v1.22.1 (#5831)
  Fix misnamed forbidden page route (#5832)
  fix(deps): update dependency concurrently to v7.2.2 (#5830)
  Router tests: More advanced auth mock (#5742)
  fix(deps): update dependency react-hook-form to v7.33.0 (#5809)
  fix(deps): update dependency qs to v6.10.5 (#5829)
  fix some grammar issues (#5778)
  fix(deps): update dependency ci-info to v3.3.2 (#5828)
  validateUniquess optional prismaClient parameter (#5763)
  fix(deps): update dependency prettier to v2.7.1 (#5808)
  fix(deps): update dependency eslint to v8.18.0 (#5806)
  fix(deps): update dependency systeminformation to v5.11.21 (#5805)
  fix(deps): update dependency @apollo/client to v3.6.9 (#5804)
  chore(deps): update dependency firebase to v9.8.3 (#5799)
  Add Azure AD B2C auth provider compatibility (#5781)
  ...
@Tobbe Tobbe deleted the tobbe-router-whileloadingauth-hook branch June 29, 2022 14:19
@jtoar jtoar modified the milestones: next-release, v2.1.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

2 participants