fix some grammar issues #5778
Merged
fix some grammar issues #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
jtoar
reviewed
Jun 21, 2022
There was a problem hiding this comment.
Hey @SwiftyProgrammer690! Thanks for taking the time to make a pull request. I don't think I agree with all of these changes, but do have a question about one:
- I've never seen a space after the semicolon in tl;dr so I'd rather leave it as is
- the other items in the list aren't punctuated so we should either punctuate them all or leave it as is
- as for "auto-deploys", I'm not sure. Do you know the grammar behind it? I.e. when to use a hyphen?
The other changes can be ignored that I have done but I am sure it should be auto-deploy instead of auto deploy. Feel free to make any changes to this @jtoar! |
jtoar
reviewed
Jun 26, 2022
jtoar
approved these changes
Jun 26, 2022
dac09
added a commit
that referenced
this pull request
Jun 27, 2022
…b-issue-forms * 'main' of github.com:redwoodjs/redwood: (40 commits) Update link to auth/providers implementations (#5826) fix(deps): update dependency qs to v6.11.0 (#5836) Docs -> Tutorial - Update comment-form.md - Minor Typo (#5837) fix: have user config for `addons` and `stories` take precedence (#5780) chore(deps): update dependency @tsconfig/docusaurus to v1.0.6 (#5834) chore(deps): update dependency @auth0/auth0-spa-js to v1.22.1 (#5831) Fix misnamed forbidden page route (#5832) fix(deps): update dependency concurrently to v7.2.2 (#5830) Router tests: More advanced auth mock (#5742) fix(deps): update dependency react-hook-form to v7.33.0 (#5809) fix(deps): update dependency qs to v6.10.5 (#5829) fix some grammar issues (#5778) fix(deps): update dependency ci-info to v3.3.2 (#5828) validateUniquess optional prismaClient parameter (#5763) fix(deps): update dependency prettier to v2.7.1 (#5808) fix(deps): update dependency eslint to v8.18.0 (#5806) fix(deps): update dependency systeminformation to v5.11.21 (#5805) fix(deps): update dependency @apollo/client to v3.6.9 (#5804) chore(deps): update dependency firebase to v9.8.3 (#5799) Add Azure AD B2C auth provider compatibility (#5781) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some grammar issues in
docs/docs/deploy/render.md!