Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fully resolves Tailwind setup command failing due to Prettier v3 dependency #9078

Closed
wants to merge 1 commit into from
Closed

fix: fully resolves Tailwind setup command failing due to Prettier v3 dependency #9078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __fixtures__/test-project/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"autoprefixer": "^10.4.14",
"postcss": "^8.4.27",
"postcss-loader": "^7.3.3",
"prettier-plugin-tailwindcss": "0.4.1",
"prettier-plugin-tailwindcss": "^0.4.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated. Recommend fully re-running update test-project command.

"tailwindcss": "^3.3.3"
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/commands/setup/ui/libraries/tailwindcss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export const handler = async ({ force, install }) => {
})
const rwPaths = getPaths()

const projectPackages = ['prettier-plugin-tailwindcss@0.4.1']
const projectPackages = ['prettier-plugin-tailwindcss']

const webWorkspacePackages = [
'postcss',
Expand Down
2 changes: 1 addition & 1 deletion tasks/test-project/tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ async function webTasks(outputPath, { linkWithLatestFwBuild, verbose }) {
// @NOTE: use rwfw, because calling the copy function doesn't seem to work here
task: () =>
execa(
'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss@0.4.1',
'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss',
[],
getExecaOptions(outputPath)
),
Expand Down
2 changes: 1 addition & 1 deletion tasks/test-project/tui-tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ async function webTasks(outputPath, { linkWithLatestFwBuild }) {
// @NOTE: use rwfw, because calling the copy function doesn't seem to work here
task: async () => {
await exec(
'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss@0.4.1',
'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss',
[],
getExecaOptions(outputPath)
)
Expand Down