Work in progress support for Rails 4 #2375
Conversation
|
@keram y u not interested in this? |
|
@simi I wish. Unfortunately we can't just merge rails4 support without hundreds of unrelated changes coming along with the commits so we've had to do our best. 😢 |
|
sorry but as parndt wroted above ;/ + this is "just" compatibility, I'm interested in complete "rails4 way". |
|
@simi @keram That's how we do it and have always done it over several years now.. first comes compatibility and then we endlessly refactor it with the help of hundreds of contributors while using it in real life applications. We try to keep change sets small, easily understood and able to be reverted. Happy to merge any commits that are in this fashion and work toward a commonly awesome goal that can be enjoyed and improved by hundreds/thousands of developers. |
|
@parndt I'm not criticizing or arguing, I just note for clarification. |
|
@keram likewise ❤️ |
…underscore seems to have gone
…as not doing it automatically.
…PATCH in preview route.
* Reduced complex syntax * Fixed some inconsistencies between form & engine
In 2.34.0 there was this what seems to be unrelated error - `cannot load such file -- zip/zip`
Fix rails4 asset_paths issues
|
@ugisozols ready to go! |
Work in progress support for Rails 4
|
@parndt ❤️ |
|
Does it mean we can use the master with Rails 4? 💃 |
|
@pusewicz yes! :) |
|
@ugisozols How far is it from 3.0.0 final? |
|
Couldn't say.. We like to use it quite a lot before releasing a final. |
|
I am unable to use master with rails 4. Am I missing something? |
|
Generating an application with it is different to using it ;) |
|
Oops. I am sorry for that. Is there any quick dirty fix to generate an application? |
|
Generate it using Rails and manually add the required gems to the Gemfile.. as we're in development there are a lot of gems you'll need. Currently: gem 'refinerycms', github: 'refinery/refinerycms', branch: 'master'
gem 'refinerycms-i18n', github: 'refinery/refinerycms-i18n', branch: 'master'
gem 'friendly_id', github: 'norman/friendly_id', branch: 'master'
gem 'friendly_id-globalize', github: 'norman/friendly_id-globalize', branch: 'master'
gem 'quiet_assets'
# Add support for refinerycms-acts-as-indexed
gem 'refinerycms-acts-as-indexed', github: 'refinery/refinerycms-acts-as-indexed'
gem 'protected_attributes'
gem 'seo_meta', github: 'parndt/seo_meta', branch: 'master'
gem 'globalize3', github: 'svenfuchs/globalize3', branch: 'rails4'
gem 'paper_trail', github: 'airblade/paper_trail', branch: 'master'
gem 'awesome_nested_set', github: 'collectiveidea/awesome_nested_set', branch: 'master' |
|
Thank you 👍 |
This is work in progress because it still has failing tests, but only a few!
I'm opening this for transparency and so that people can help! 👍
cc @ugisozols