Implement Baskets MsgServer

[blushi]

Summary

Based on the msg service definition from #610 and initial work from Lisbon sprint #618, add MsgServer implementation for baskets in x/ecocredit

Adding unit tests on the MsgServer will also be included in this PR.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[clevinson]

@technicallyty We've had several product conversations over the past few days this week that may impact the work you're doing on this issue.

For now, let's keep the MsgServer implementation focused on the core logic (storing basket tokens in x/bank, tracking balances in x/ecocredit, etc.). When it comes to implementing the filter criteria for baskets, let's prioritize filtering by class_id and credit_type_name, and leave the logical operators (AND / OR) + the rest of the filter criteria fields unimplemented for now -- until we have more clarity on the requirements.

Pick & Take from basket functionality should be good to implement as well.

[technicallyty]

i have a draft PR up now. linked it to this issue. reposting the questions here for discussion:

Questions

• Should we allow basket's to have no filter?
• TakeFromBasket only returns tradable amounts, but this method can also result in credits being retired. should we include a RetiredAmount in the response message?
• Say someone submits a TakeFromBasket tx with a requested amount of 3.123456789, and one of the batches in the basket has a precision of 6. What do we do in this case?
• Should we cache the total number of credits in the basket table in ORM? this could save us a lot of computation time in TakeFromBasket where we iterate over all the coins, and fail if there aren't enough for the swap. cacheing the amount would allow us to fail early if a user requests more than the basket has.
• Should the basket curator be allowed to pick if picking is disabled?
• Should filters have depth limits? (to stop people from doing stuff like Filter_And[Filter_And[Filter_and[Filter_And[Filter_and...]]]])
• What is the basket display name for? how should it be validated?
• should we allow basket exponents of 0? this would result in a 1:1 of basket token -> basket credit.
• currently i loop over all the batches in the basket, then sort by start date. is this the best/only way?
• How should the basket's coin denom be formed? currently i just use the basket name, but i feel it could be abused by people naming their basket OSMO, and tricking folks. Perhaps we could prefix basket coins with bskt so we would have bsktFooBasket?

[aaronc]

@technicallyty can you find 15-30 minutes for a live review this week and also invite @clevinson and @ryanchristo ?

[technicallyty]

@technicallyty can you find 15-30 minutes for a live review this week and also invite @clevinson and @ryanchristo ?

cory will be out starting tmrw and back next wednesday - should we wait til then?

[aaronc]

Sure