-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basket msg server #686
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some notes from our call in case you missed something: Create basket:
Add Basket:
TakeFromBasket:
Filter:
|
ON HOLD : blocked by orm code gen work in SDK. |
closing as we can just port #732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds baskets
Basket AddressesBaskets now derive an address upon creation. This allows us to use our existing ecocredit query endpoints without having to add basket specific queries. Need to know the balance of a basket? call the existingBalance
endpoint with the basket's address.This may not be the most ideal solution as a potential attack vector would be to send credits to this address using the Send method, effectively bypassing the filter. we could give basket addresses a custom prefixregenbskt1v32....
and haveSend
actively check for this. not too sure if that's ideal, so curious to hear thoughts on it.Basket Coin Denom
Currently, I use the basket name as the token denom alone. This is placeholder for a better solution. The name is used as the coin denom for the basket's token.
To avoid being confused with other tokens on regen network, i think basket tokens should have a prefix before the basket name as their token name. Similar
wBTC
for wrapped bitcoin, we could do something likebsktFooBasket
for a token fromFooBasket
. This would be good for UX, especially in the case where a troublemaker might make a basket calledOSMO
and try to fool people with the basket token.Questions
RetiredAmount
in the response message?TakeFromBasket
where we iterate over all the coins, and fail if there aren't enough for the swap. cacheing the amount would allow us to fail early if a user requests more than the basket has.Stuff that still needs to be implemented:
batches no older than 3 years ago
Closes: #634
Closes: #683
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change