feat(x/ecocredit): add basket API #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
requested review from
ruhatch,
blushi,
clevinson,
dtkong,
glandua,
robert-zaremba,
S4mmyb and
technicallyty
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 74.09% 75.76% +1.67%
==========================================
Files 104 104
Lines 14899 14222 -677
==========================================
- Hits 11039 10775 -264
+ Misses 3131 2801 -330
+ Partials 729 646 -83
Flags with carried forward coverage won't be shown. Click here to find out more. |
aaronc
changed the title
Co-authored-by: Tyler <[email protected]>
amaury1093
reviewed
Nov 3, 2021
amaury1093
reviewed
Nov 3, 2021
19 tasks
blushi
reviewed
Nov 3, 2021
technicallyty
approved these changes
Nov 3, 2021
ryanchristo
reviewed
Nov 10, 2021
amaury1093
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
pre-approving, pending on #610 (comment) and #610 (comment)
| @@ -52,6 +53,30 @@ service Msg { | |||
|
|
|||
| // AllowAskDenom is a governance operation which authorizes a new ask denom to be used in sell orders | |||
| rpc AllowAskDenom (MsgAllowAskDenom) returns (MsgAllowAskDenomResponse); | |||
|
|
|||
| // CreateBasket creates a bank denom which wraps credits. | |||
There was a problem hiding this comment.
Suggested change
| // CreateBasket creates a bank denom which wraps credits. | |
| // CreateBasket creates a bank denom which wraps credits. | |
| // Baskets are managed and created by Regen Ledger governance (REGEN holders). | |
| // This means that basket creation and basket composition updates goes through | |
| // governance processes and module parameters. |
adding 578bbbd from the sprint
There was a problem hiding this comment.
But how is governance controlling this? Don't we need to modify the API?
5 tasks
This was referenced Nov 10, 2021
robert-zaremba
approved these changes
Nov 11, 2021
This was referenced Nov 15, 2021
…into aaronc/ecocredit-basket
This was referenced Nov 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basket functionality to x/ecocredit.
Currently editing basket criteria is not supported because it needs to be thought through more.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change