Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all relevant go.mod's to Go 1.18 #1088

Merged
merged 4 commits into from
May 5, 2022
Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented May 4, 2022

Description

  • updates all go.mod's to use 1.18 (sans x/group).

Closes: #1082


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1088 (7d2be1d) into master (cfd8d1d) will increase coverage by 6.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   61.72%   67.99%   +6.27%     
==========================================
  Files         203      206       +3     
  Lines       18953    20839    +1886     
==========================================
+ Hits        11699    14170    +2471     
+ Misses       6012     5358     -654     
- Partials     1242     1311      +69     
Flag Coverage Δ
experimental-codecov 67.88% <ø> (?)
stable-codecov 61.74% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@technicallyty technicallyty changed the title chore: update all relevant go.mod's chore: update all relevant go.mod's to Go 1.18 May 4, 2022
@@ -1,4 +1,4 @@
FROM golang:1.17-alpine AS build
FROM golang:1.18-alpine AS build
Copy link
Contributor

@aleem1314 aleem1314 May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the go version in GitHub actions.

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre approving

@technicallyty technicallyty merged commit 8231250 into master May 5, 2022
@technicallyty technicallyty deleted the ty/gomods branch May 5, 2022 16:23
@ryanchristo ryanchristo mentioned this pull request May 5, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all go modules to go version 1.18
3 participants