feat: Add baskets Query API #628
Conversation
amaury1093
requested review from
aaronc,
blushi,
clevinson,
dtkong,
robert-zaremba,
ryanchristo and
technicallyty
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 72.11% 73.58% +1.47%
==========================================
Files 107 105 -2
Lines 15212 14832 -380
==========================================
- Hits 10970 10914 -56
+ Misses 3481 3164 -317
+ Partials 761 754 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
R4R! Proto lint is failing because some fields are missing comments. I'll be out for 1 week, does someone want to take over and add some comments on proto files? |
@AmauryM I can work on that! |
| // Basket defines a credit basket. | ||
| message Basket { |
There was a problem hiding this comment.
Should we move this to types.proto?
There was a problem hiding this comment.
it's only being used for queries so I'd rather keep it in query.proto
| // multiplier is an integer number which is applied to credit units when | ||
| // converting to basket units. For example if the multiplier is 2000, then | ||
| // 1.1 credits will result in 2200 basket tokens. If there are any fractional | ||
| // amounts left over in this calculation when adding credits to a basket, | ||
| // those fractional amounts will not get added to the basket. | ||
| string multiplier = 2; |
There was a problem hiding this comment.
It looks like there are some conflicts that will occur here with #649. We are removing BasketCriteria and using Filter directly within MsgCreateBasket but I think this move was the right idea.
There was a problem hiding this comment.
good to know, let's see which one gets merged first!
|
Closes #648 ? |
Co-authored-by: Ryan Christoffersen <[email protected]>
Description
Closes #648
The initial PR by aaron #610 only added Protobuf Msgs. This PR adds some Query endpoints.
Depends on:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change