feat(remix-dev): deprecate serverBuildTarget

[MichaelDeBoey]

As discussed in the second roadmap livestream

---

Closes #3556

[changeset-bot]

⚠️ No Changeset found

Latest commit: bdc6ff1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[jenseng]

Between this and #4842 are we missing anything? I see there are some places where we key off of this in the compiler (e.g. here), do we need additional config to support this behavior?

[MichaelDeBoey]

@jenseng Good call!
That's indeed something we need to figure out in some other way 🤔

Listing all the usages:

• remix/packages/remix-dev/compiler/compilerServer.ts

  Lines 45 to 48 in 6a6fa59

  	let isCloudflareRuntime = ["cloudflare-pages", "cloudflare-workers"].includes(
  	config.serverBuildTarget ?? ""
  	);
  	let isDenoRuntime = config.serverBuildTarget === "deno";

• remix/packages/remix-dev/compiler/plugins/serverBareModulesPlugin.ts

  Line 24 in 6a6fa59

  let isDenoRuntime = remixConfig.serverBuildTarget === "deno";

• remix/packages/remix-dev/compiler/plugins/serverBareModulesPlugin.ts

  Lines 95 to 101 in 6a6fa59

  	switch (remixConfig.serverBuildTarget) {
  	// Always bundle everything for cloudflare.
  	case "cloudflare-pages":
  	case "cloudflare-workers":
  	case "deno":
  	return undefined;
  	}

• remix/packages/remix-dev/compiler/plugins/serverBareModulesPlugin.ts

  Lines 116 to 117 in 6a6fa59

  	(!remixConfig.serverBuildTarget ||
  	remixConfig.serverBuildTarget === "node-cjs")

[MichaelDeBoey]

@harmony7 mentioned the same problem in #4860 regarding not being able to fully deprecate serverBuildtarget

This PR is necessary because, except for the first two subitems in the list above, these behaviors cannot be set through remix.config.js.

[harmony7]

Looks like this is going to be solving #4615 that was one of my concerns, too. Thanks.

[mcansh]

bundling everything should be achievable using serverDependenciesToBundle: /.*/, but still need a way to set conditions, minify, and mainfield for esbuild

[MichaelDeBoey]

@mcansh So how do you think that would that look like?
Creating new serverConditions, serverMinify & serverMainFields config options?

If so, I would suggest to go with a server object instead, to not pollute the global config namespace.

CC/ @mjackson @ryanflorence

[mjackson]

new serverConditions, serverMinify & serverMainFields config options

Yeah, @MichaelDeBoey. I think we will need these.

If so, I would suggest to go with a server object instead, to not pollute the global config namespace.

No, let's keep the config object as flat as possible.

[MichaelDeBoey]

@mjackson I introduced the serverConditions, serverMinify & serverMainFields config options and updated serverDependenciesToBundle so that it can also receive "all" as value.

The only places where we're now still using serverBuildTarget is in serverBareModulesPlugin:

• remix/packages/remix-dev/compiler/plugins/serverBareModulesPlugin.ts

  Lines 24 to 37 in 6a6fa59

  	let isDenoRuntime = remixConfig.serverBuildTarget === "deno";
  	// Resolve paths according to tsconfig paths property
  	let matchPath = isDenoRuntime
  	? undefined
  	: createMatchPath(remixConfig.tsconfigPath);
  	function resolvePath(id: string) {
  	if (!matchPath) {
  	return id;
  	}
  	return (
  	matchPath(id, undefined, undefined, [".ts", ".tsx", ".js", ".jsx"]) || id
  	);
  	}

• remix/packages/remix-dev/compiler/plugins/serverBareModulesPlugin.ts

  Lines 116 to 117 in 6a6fa59

  	(!remixConfig.serverBuildTarget ||
  	remixConfig.serverBuildTarget === "node-cjs")

Can't think of a good way to remove usage here though 🤔

CC/ @jacob-ebey @mcansh @pcattori as you have been working in this file on the parts that still need a solution.

[harmony7]

awesome stuff! =)

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-79859c9-20230203 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[TrySound]

Client conditions would be useful too
#6003