Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file extensions to compiler/loaders #5018

Closed
wants to merge 0 commits into from
Closed

Conversation

staylor
Copy link
Contributor

@staylor staylor commented Jan 6, 2023

Closes: #5019

These extensions are used on some routes on the Shopify website.

Testing Strategy:

Try importing a .mov file - a URL should be returned, instead of a loader error.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2023

⚠️ No Changeset found

Latest commit: 45d4491

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 6, 2023

Hi @staylor,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 6, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@staylor staylor marked this pull request as ready for review January 6, 2023 07:20
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

New extensions should also be declared in packages/remix-dev/modules.ts

See https://github.com/remix-run/remix/pull/3985/files for an example

@machour
Copy link
Collaborator

machour commented Jan 6, 2023

You also need to target the dev branch instead of main since your updating the source code.
Could you also take a look at the changesets comment above, and generate the changeset for this PR? 🙏🏼

@staylor staylor changed the base branch from main to dev January 9, 2023 13:57
@staylor staylor closed this Jan 9, 2023
@staylor
Copy link
Contributor Author

staylor commented Jan 9, 2023

fresh branch over here: #5030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some file extensions are missing in compiler/loaders
3 participants