-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file extensions to compiler/loaders #5018
Conversation
|
Hi @staylor, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
New extensions should also be declared in packages/remix-dev/modules.ts
See https://github.com/remix-run/remix/pull/3985/files for an example
You also need to target the |
fresh branch over here: #5030 |
Closes: #5019
These extensions are used on some routes on the Shopify website.
Testing Strategy:
Try importing a
.mov
file - a URL should be returned, instead of a loader error.