Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: use TS server file #5822

Conversation

MichaelDeBoey
Copy link
Member

We use TS in all our docs & examples, so let's make these templates as much TS as possible

We have a TS server file in our grunge stack as well

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

⚠️ No Changeset found

Latest commit: 58a77cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the use-typescript-server-file-in-templates branch 3 times, most recently from 33a4289 to 8922f83 Compare March 23, 2023 17:03
@MichaelDeBoey MichaelDeBoey force-pushed the use-typescript-server-file-in-templates branch 5 times, most recently from dd09e92 to e66d3c6 Compare April 1, 2023 13:12
@MichaelDeBoey MichaelDeBoey force-pushed the use-typescript-server-file-in-templates branch 2 times, most recently from 5a780b1 to 9d280e4 Compare April 10, 2023 17:07
@MichaelDeBoey MichaelDeBoey force-pushed the use-typescript-server-file-in-templates branch from 9d280e4 to 24b039a Compare April 11, 2023 21:15
@MichaelDeBoey MichaelDeBoey requested a review from mcansh April 11, 2023 21:15
@MichaelDeBoey MichaelDeBoey force-pushed the use-typescript-server-file-in-templates branch 2 times, most recently from 200ce48 to dadc317 Compare April 11, 2023 21:42
@MichaelDeBoey MichaelDeBoey force-pushed the use-typescript-server-file-in-templates branch from dadc317 to 58a77cb Compare April 13, 2023 20:04
@jacob-ebey jacob-ebey merged commit 848fb8f into remix-run:main Apr 13, 2023
@jacob-ebey
Copy link
Member

Thanks for this @MichaelDeBoey, been wanting to do this for a while.

@MichaelDeBoey MichaelDeBoey deleted the use-typescript-server-file-in-templates branch April 14, 2023 00:28
@rossipedia
Copy link
Contributor

This broke create-remix for express :(

@lili21
Copy link
Contributor

lili21 commented Apr 23, 2023

error message after run npm run dev in express template

[nodemon] starting `cross-env NODE_ENV=production node ./server.js --require dotenv/config ./server.js`
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '/Users/admin/just-for-fun/try-remix15/server.js'

@MichaelDeBoey
Copy link
Member Author

@rossipedia @lili21 I'm fixing this in #6145
Feedback is welcome over there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants