Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-cloudflare-pages): fix GetLoadContextFunction type #6041

Conversation

MichaelDeBoey
Copy link
Member

Due to @mcansh's remark in #5822 (comment), I noticed that the CP adapter's GetLoadContextFunction was wrong

With this PR, we derive context from @cloudflare/workers-types' PagesFunction

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

⚠️ No Changeset found

Latest commit: 8991950

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey merged commit 8f1741c into remix-run:dev Apr 11, 2023
@MichaelDeBoey MichaelDeBoey deleted the fix-GetLoadContextFunction-type-for-CP-adapter branch April 11, 2023 22:10
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9af8868-20230412 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants